Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1869312: Add @natiiix to OWNERS #154

Merged
merged 1 commit into from Aug 10, 2020

Conversation

natiiix
Copy link
Contributor

@natiiix natiiix commented Aug 6, 2020

I have been working on the Insights Operator for a while now and having the permissions would be helpful. Right now I can't use many of the OpenShift bot commands. Ricardo will soon, hopefully, start working on the Insights Operator as well, so it may be for the best to add both of us at once.

@openshift-ci-robot
Copy link
Contributor

Hi @natiiix. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Aug 6, 2020
@alexandrevicenzi
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 6, 2020
@alexandrevicenzi
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@natiiix
Copy link
Contributor Author

natiiix commented Aug 7, 2020

/retest

@natiiix
Copy link
Contributor Author

natiiix commented Aug 7, 2020

/verify-owners

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2020
@natiiix natiiix changed the title Add @natiiix and @rluders to OWNERS Add @natiiix to OWNERS Aug 10, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 10, 2020
Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM of course :)

@tisnik
Copy link
Contributor

tisnik commented Aug 10, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandrevicenzi, natiiix, tisnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexandrevicenzi,tisnik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2020
@natiiix
Copy link
Contributor Author

natiiix commented Aug 10, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3624015 into openshift:master Aug 10, 2020
@natiiix
Copy link
Contributor Author

natiiix commented Aug 11, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot

@natiiix: new pull request created: #156

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@natiiix
Copy link
Contributor Author

natiiix commented Aug 11, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot

@natiiix: #154 failed to apply on top of branch "release-4.4":

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@natiiix
Copy link
Contributor Author

natiiix commented Aug 17, 2020

/retitle Bug 1869312: Add @natiiix to OWNERS

@openshift-ci-robot openshift-ci-robot changed the title Add @natiiix to OWNERS Bug 1869312: Add @natiiix to OWNERS Aug 17, 2020
@openshift-ci-robot
Copy link
Contributor

@natiiix: All pull requests linked via external trackers have merged: . Bugzilla bug 1869312 has been moved to the MODIFIED state.

In response to this:

Bug 1869312: Add @natiiix to OWNERS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@natiiix
Copy link
Contributor Author

natiiix commented Aug 17, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot

@natiiix: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/insights-operator\n ! [rejected] cherry-pick-154-to-release-4.5 -> cherry-pick-154-to-release-4.5 (non-fast-forward)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/insights-operator'\nhint: Updates were rejected because the tip of your current branch is behind\nhint: its remote counterpart. Integrate the remote changes (e.g.\nhint: 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants