New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1886462: Add the namespace to the gatherers reports to avoid conflicts #209
Bug 1886462: Add the namespace to the gatherers reports to avoid conflicts #209
Conversation
Skipping CI for Draft Pull Request. |
@rluders: This pull request references Bugzilla bug 1886462, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d91148a
to
13a1b60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks ok!
I went one step further in this one, 'cause I noticed that the same issue could be happening with other gatherers. So, I guess that know, it assure that whenever we have a namespace, the report should be stored under the namespace's folder. It would need some changes in the tests, and also, probably we want to want to release notes for our users. 'Cause this change is a potential breaker. |
Thanks @rluders, nice work. It looks only PDBs and MachineSets are NS scoped. Maybe we could add investigation of this add to our "adding new data" document.. |
/lgtm |
Tested it locally, works as expected :) /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0sewa0, martinkunc, rluders, tisnik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@rluders: All pull requests linked via external trackers have merged: Bugzilla bug 1886462 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix collisions between pdbs with the same name but living in different namespaces.