Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1886462: Add the namespace to the gatherers reports to avoid conflicts #209

Merged

Conversation

rluders
Copy link
Contributor

@rluders rluders commented Oct 8, 2020

Fix collisions between pdbs with the same name but living in different namespaces.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2020
@openshift-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2020
@rluders rluders changed the title Add the namespace to pdbs reports filename. Bug 1886462: Add the namespace to pdbs reports filename. Oct 8, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 8, 2020
@openshift-ci-robot
Copy link
Contributor

@rluders: This pull request references Bugzilla bug 1886462, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1886462: Add the namespace to pdbs reports filename.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 8, 2020
Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok!

@rluders
Copy link
Contributor Author

rluders commented Oct 8, 2020

I went one step further in this one, 'cause I noticed that the same issue could be happening with other gatherers. So, I guess that know, it assure that whenever we have a namespace, the report should be stored under the namespace's folder.

It would need some changes in the tests, and also, probably we want to want to release notes for our users. 'Cause this change is a potential breaker.

@rluders rluders changed the title Bug 1886462: Add the namespace to pdbs reports filename. Bug 1886462: Add the namespace to the gatherers reports to avoid conflicts Oct 8, 2020
@rluders rluders marked this pull request as ready for review October 8, 2020 16:34
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2020
@rluders rluders requested a review from tisnik October 8, 2020 17:51
@martinkunc
Copy link
Contributor

Thanks @rluders, nice work. It looks only PDBs and MachineSets are NS scoped. Maybe we could add investigation of this add to our "adding new data" document..

@martinkunc
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@0sewa0
Copy link
Contributor

0sewa0 commented Oct 9, 2020

Tested it locally, works as expected :)

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, martinkunc, rluders, tisnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [0sewa0,martinkunc,rluders,tisnik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3f00deb into openshift:master Oct 9, 2020
@openshift-ci-robot
Copy link
Contributor

@rluders: All pull requests linked via external trackers have merged:

Bugzilla bug 1886462 has been moved to the MODIFIED state.

In response to this:

Bug 1886462: Add the namespace to the gatherers reports to avoid conflicts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants