[release 4.6] Bug 1887759: Adds MachineConfigPool gatherer #213

0sewa0 · 2020-10-13T09:48:22Z

Backports (4.6) a new data enhancement for gathering MachineConfigPools.

Sample archive

docs/insights-archive-sample/config/machineconfigpools/master.json
docs/insights-archive-sample/config/machineconfigpools/worker.json

Documentation

docs/gathered-data.md

Unit Tests

pkg/gather/clusterconfig/clusterconfig_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

References

https://issues.redhat.com/browse/CCXDEV-3285
https://issues.redhat.com/browse/INSIGHTOCP-84
https://bugzilla.redhat.com/show_bug.cgi?id=1887759

openshift-ci-robot · 2020-10-13T09:48:27Z

@0sewa0: This pull request references Bugzilla bug 1887759, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "4.6.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release 4.6] Bug 1887759: Adds MachineConfigPool gatherer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

0sewa0 · 2020-10-13T10:40:30Z

/bugzilla refresh

openshift-ci-robot · 2020-10-13T10:40:36Z

@0sewa0: This pull request references Bugzilla bug 1887759, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "4.6.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

0sewa0 · 2020-10-13T11:18:56Z

/retest

tremes · 2020-10-13T13:40:46Z

Verified on QuickLab clusters. We should just doublecheck the permission for the new apiGroup.
/lgtm

openshift-bot · 2020-10-13T14:03:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-13T14:23:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-13T15:02:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-14T01:00:09Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-14T01:00:13Z

@openshift-bot: This pull request references Bugzilla bug 1887759, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "4.6.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

martinkunc · 2020-10-14T08:50:48Z

/bugzilla refresh

openshift-ci-robot · 2020-10-14T08:50:52Z

@martinkunc: This pull request references Bugzilla bug 1887759, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "4.6.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

0sewa0 · 2020-10-14T09:45:22Z

/bugzilla refresh

openshift-ci-robot · 2020-10-14T09:45:30Z

@0sewa0: This pull request references Bugzilla bug 1887759, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1886751 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1886751 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tremes · 2020-10-29T14:22:17Z

@sdodson Can you please take a look at this one and add cherry-pick approved label please?

sdodson · 2020-10-29T19:36:11Z

Does this in any way impact cluster stability or upgrade success?

…

On Thu, Oct 29, 2020 at 10:22 AM Tomas Remes ***@***.***> wrote: @sdodson <https://github.com/sdodson> Can you please take a look at this one and add cherry-pick approved label please? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#213 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALYIMQV3BASQMRXXCVJR3SNF3CTANCNFSM4SOQCPXQ> .

sdodson · 2020-11-09T16:01:22Z

(Patch Manager) This PR was reviewed for inclusion last week, however this adds feature work during the weeks immediately after release where we're focused on stability, upgrade success, and anything which blocks backports of critical customer impacting bugs. Since this doesn't meet those criteria it was not accepted last week and likely will not until we've been able to promote the 4.5 to 4.6 upgrade to the stable channel.

sferich888 · 2020-11-20T12:40:48Z

@sdodson if PX approves backports like, this would that help unstick this PR's current state?

openshift-ci-robot · 2020-12-09T11:00:14Z

@0sewa0: This pull request references Bugzilla bug 1887759, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1886751 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1886751 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

[release 4.6] Bug 1887759: Adds MachineConfigPool gatherer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson · 2020-12-09T16:41:55Z

/bugzilla refresh

openshift-ci-robot · 2020-12-09T16:43:01Z

@sdodson: This pull request references Bugzilla bug 1887759, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1886751 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1886751 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

0sewa0 · 2021-01-28T10:03:22Z

/retest

0sewa0 · 2021-01-28T10:42:28Z

/retest

0sewa0 · 2021-01-28T11:05:05Z

/retest

tremes · 2021-01-28T11:23:49Z

Verified again. Works as expected.
/lgtm

openshift-ci-robot · 2021-01-28T11:24:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [0sewa0,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

0sewa0 · 2021-01-28T11:58:28Z

/retest

0sewa0 · 2021-01-28T12:24:55Z

/retest

0sewa0 · 2021-01-28T12:42:56Z

/retest

0sewa0 · 2021-01-28T14:09:44Z

/retest

0sewa0 · 2021-01-28T15:50:51Z

/retest

openshift-ci-robot · 2021-01-28T17:40:15Z

@0sewa0: All pull requests linked via external trackers have merged:

openshift/insights-operator#213

Bugzilla bug 1887759 has been moved to the MODIFIED state.

In response to this:

[release 4.6] Bug 1887759: Adds MachineConfigPool gatherer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 13, 2020

openshift-ci-robot requested review from tisnik and tremes October 13, 2020 09:48

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2020

openshift-ci-robot assigned tremes Oct 13, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 14, 2020

openshift-ci-robot removed the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Dec 9, 2020

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Dec 9, 2020

jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 27, 2021

0sewa0 force-pushed the 4.6_MDCs branch from c639377 to f2a97ff Compare January 28, 2021 08:32

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2021

Adds MachineConfigPool gatherer

290ef98

0sewa0 force-pushed the 4.6_MDCs branch from f2a97ff to 290ef98 Compare January 28, 2021 08:38

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2021

openshift-merge-robot merged commit 2770bc1 into openshift:release-4.6 Jan 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release 4.6] Bug 1887759: Adds MachineConfigPool gatherer #213

[release 4.6] Bug 1887759: Adds MachineConfigPool gatherer #213

0sewa0 commented Oct 13, 2020 •

edited

openshift-ci-robot commented Oct 13, 2020

0sewa0 commented Oct 13, 2020

openshift-ci-robot commented Oct 13, 2020

0sewa0 commented Oct 13, 2020

tremes commented Oct 13, 2020

openshift-bot commented Oct 13, 2020

openshift-bot commented Oct 13, 2020

openshift-bot commented Oct 13, 2020

openshift-bot commented Oct 14, 2020

openshift-ci-robot commented Oct 14, 2020

martinkunc commented Oct 14, 2020

openshift-ci-robot commented Oct 14, 2020

0sewa0 commented Oct 14, 2020

openshift-ci-robot commented Oct 14, 2020

tremes commented Oct 29, 2020

sdodson commented Oct 29, 2020 via email

sdodson commented Nov 9, 2020

sferich888 commented Nov 20, 2020

openshift-ci-robot commented Dec 9, 2020

sdodson commented Dec 9, 2020

openshift-ci-robot commented Dec 9, 2020

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

tremes commented Jan 28, 2021

openshift-ci-robot commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

openshift-ci-robot commented Jan 28, 2021

[release 4.6] Bug 1887759: Adds MachineConfigPool gatherer #213

[release 4.6] Bug 1887759: Adds MachineConfigPool gatherer #213

Conversation

0sewa0 commented Oct 13, 2020 • edited

Categories

Sample archive

Documentation

Unit Tests

Privacy

References

openshift-ci-robot commented Oct 13, 2020

0sewa0 commented Oct 13, 2020

openshift-ci-robot commented Oct 13, 2020

0sewa0 commented Oct 13, 2020

tremes commented Oct 13, 2020

openshift-bot commented Oct 13, 2020

openshift-bot commented Oct 13, 2020

openshift-bot commented Oct 13, 2020

openshift-bot commented Oct 14, 2020

openshift-ci-robot commented Oct 14, 2020

martinkunc commented Oct 14, 2020

openshift-ci-robot commented Oct 14, 2020

0sewa0 commented Oct 14, 2020

openshift-ci-robot commented Oct 14, 2020

tremes commented Oct 29, 2020

sdodson commented Oct 29, 2020 via email

sdodson commented Nov 9, 2020

sferich888 commented Nov 20, 2020

openshift-ci-robot commented Dec 9, 2020

sdodson commented Dec 9, 2020

openshift-ci-robot commented Dec 9, 2020

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

tremes commented Jan 28, 2021

openshift-ci-robot commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

openshift-ci-robot commented Jan 28, 2021

0sewa0 commented Oct 13, 2020 •

edited