Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TestArchiveUploadedAndResultReceived #241

Merged
merged 3 commits into from Oct 30, 2020
Merged

Added TestArchiveUploadedAndResultReceived #241

merged 3 commits into from Oct 30, 2020

Conversation

quarckster
Copy link
Contributor

No description provided.

@quarckster quarckster changed the title Added TestArchiveUploadedAndResultReceived [WIP] Added TestArchiveUploadedAndResultReceived Oct 28, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2020
@quarckster
Copy link
Contributor Author

/retest

2 similar comments
@quarckster
Copy link
Contributor Author

/retest

@quarckster
Copy link
Contributor Author

/retest

@quarckster
Copy link
Contributor Author

/retest

@quarckster quarckster changed the title [WIP] Added TestArchiveUploadedAndResultReceived Added TestArchiveUploadedAndResultReceived Oct 28, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2020
psimovec
psimovec reviewed Oct 29, 2020
View reviewed changes
Copy link
Member

@psimovec psimovec left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!
I was going to comment that logLineTime expects the line to be in the logs. But you did the necessary changes already.

It definitely makes sense to have such test.

Only thing that I'd point out is that the logged times can be incorrect as the logLineTime function captures just HH:MM:SS. edit: explained in DMs that it happens in case when second logLineTime appears in different day than first one.

Otherwise LGTM

@psimovec
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 29, 2020
@quarckster
Copy link
Contributor Author

/retest

2 similar comments
@quarckster
Copy link
Contributor Author

/retest

@quarckster
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020
@quarckster
Copy link
Contributor Author

/retest

2 similar comments
@quarckster
Copy link
Contributor Author

/retest

@quarckster
Copy link
Contributor Author

/retest

@psimovec
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psimovec, quarckster

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8c6e1f5 into openshift:master Oct 30, 2020
@quarckster quarckster deleted the e2e-test branch October 30, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psimovec psimovec psimovec left review comments

@alexandrevicenzi alexandrevicenzi Awaiting requested review from alexandrevicenzi

@martinkunc martinkunc Awaiting requested review from martinkunc

Assignees

@psimovec psimovec

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@quarckster @psimovec @openshift-bot @openshift-ci-robot @openshift-merge-robot