Separating the gather logic into separate files #257
Conversation
openshift-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/test ci/prow/insights-operator-e2e-tests |
|
@0sewa0: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test insights-operator-e2e-tests |
1 similar comment
|
/test insights-operator-e2e-tests |
|
Tested locally. And... it works. 👍 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0sewa0, rluders The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
BE AWARE THIS IS A FAT ONE.
So to save time and pain in the future there is a major refactor necessary for the
clusterconfig.go. Its an unmaintainable mess of code thats 2000 lines long. This PR splits it up into individual files.There are still some problematic parts like the
0-utils.gowhich contains all the code that was shared between the gather functions and it should be refactored further.versions.gois also problematic because it has 2 gather functions in it, one of which relies on the other, which we don't want.Also gather-clients are now created where they will be used and not passed down from three levels higher. Only the configs and context is provided to the gather-functions.