Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1916843: collect logs from openshift-sdn-controller pod #314

Conversation

Serhii1011010
Copy link
Contributor

@Serhii1011010 Serhii1011010 commented Jan 14, 2021

sdn-controller (openshift-sdn namespace) emits important messages when it finds issues affecting Egress IPs. The important messages are the following:

“Node %s is not Ready”: A node has been set offline for egress IPs because it is reported not ready at API
“Node %s may be offline... retrying”: An egress node has failed the egress IP health check once, so it has big chances to be marked as offline soon or, at the very least, there has been a connectivity glitch.
“Node %s is offline”: An egress node has failed enough probes to have been marked offline for egress IPs. If it has egress CIDRs assigned, its egress IPs have been moved to other nodes. Indicates issues at either the node or the network between the master and the node.
“Node %s is back online”: This indicates that a node has recovered from the condition described at the previous message, by starting succeeding the egress IP health checks. Useful just in case that previous “Node %s is offline” messages are lost, so that we have a clue that there was failure previously.

As IO is gathered every 2hrs we want to gather latest occurrences of those errors in logs

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

  • config/pod/openshift-sdn/logs/{pod-name}/errors.log

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gather/clusterconfig/gather_logs_test.go improved

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

// TODO:

References

https://issues.redhat.com/browse/CCXDEV-3607
https://bugzilla.redhat.com/show_bug.cgi?id=1916843
https://access.redhat.com/solutions/???

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021
@Serhii1011010 Serhii1011010 changed the title [WIP] collect logs from openshift-sdn-controller pod collect logs from openshift-sdn-controller pod Jan 15, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2021
@Serhii1011010 Serhii1011010 changed the title collect logs from openshift-sdn-controller pod Bug 1916843: collect logs from openshift-sdn-controller pod Jan 15, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 15, 2021
@openshift-ci-robot
Copy link
Contributor

@Sergey1011010: This pull request references Bugzilla bug 1916843, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1916843: collect logs from openshift-sdn-controller pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 15, 2021
@Serhii1011010
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 15, 2021
@openshift-ci-robot
Copy link
Contributor

@Sergey1011010: This pull request references Bugzilla bug 1916843, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Serhii1011010
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

@Sergey1011010: This pull request references Bugzilla bug 1916843, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1916843: collect logs from openshift-sdn-controller pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Serhii1011010
Copy link
Contributor Author

/retest

@tremes
Copy link
Contributor

tremes commented Jan 19, 2021

Verified locally with some other message from sdn-controller pod (we will need to update the sample archive once we have some example log). Thanks
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2021
@tremes
Copy link
Contributor

tremes commented Jan 19, 2021

We should be able to get some example log based on the steps mentioned in https://issues.redhat.com/browse/CCXDEV-3607. Please try to update the PR to contain the sample archive update.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2021
@tremes
Copy link
Contributor

tremes commented Jan 21, 2021

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2021
@tremes
Copy link
Contributor

tremes commented Jan 21, 2021

/lgtm

@tremes
Copy link
Contributor

tremes commented Jan 21, 2021

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2021
@Serhii1011010
Copy link
Contributor Author

/retest

@Serhii1011010
Copy link
Contributor Author

/retest

@tremes
Copy link
Contributor

tremes commented Jan 21, 2021

I only checked the last commits.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sergey1011010, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sergey1011010,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b653953 into openshift:master Jan 21, 2021
@openshift-ci-robot
Copy link
Contributor

@Sergey1011010: All pull requests linked via external trackers have merged:

Bugzilla bug 1916843 has been moved to the MODIFIED state.

In response to this:

Bug 1916843: collect logs from openshift-sdn-controller pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants