Bug 1925408: Remove StatefulSet gatherer & replace it with gathering "cluster-mon…

[tremes]

…itoring-config" config map

This removes original StatefulSet gatherer. The information can be obtained from cluster-monitoring-config config map.

Categories

• Bugfix
• Enhancement
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample archive

TODO

Documentation

TODO

Unit Tests

No new test

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

References

https://issues.redhat.com/browse/CCXDEV-3970
https://issues.redhat.com/browse/INSIGHTOCP-51
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???

[0sewa0]

would it make sense to have the stateful-set gathering in its own file and its own gathering function ?

[tremes]

@0sewa0 We don't need StatefulSet gathering for anything as far as I know.

[0sewa0]

@tremes I meant the gatherMonitoringCM part

[tremes]

@0sewa0 gatherMonitoringCM is gathering just another configmap. I can't see any advantage of having it in its own file TBH. I think it's better to keep gatherting of the same resources in one gatherer if possbile. I guess I don't want to have e.g config_maps_1.go for let's say config maps from openshift-config namespace and config_maps_2.go for config maps from some other namespace.

[0sewa0]

@tremes that makes sense, thx :)
the code looks good, maybe the names at https://github.com/openshift/insights-operator/pull/329/files#diff-384b761d21c5b0abe263caf445c6c026d977784e53da51915369f8daf39e4d6dR37 could use an update to something similar 1 line under that

[tremes]

/test e2e-gcp-upgrade

[natiiix]

Tested locally against a shared OCP 4.6 cluster on QuickLab.

The gathered archive contained the config/configmaps/openshift-monitoring/cluster-monitoring-config/config.json file as advertised.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natiiix, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [natiiix,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@tremes: This pull request references Bugzilla bug 1925408, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1925408: Remove StatefulSet gatherer & replace it with gathering "cluster-mon…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@tremes: All pull requests linked via external trackers have merged:

• openshift/insights-operator#329

Bugzilla bug 1925408 has been moved to the MODIFIED state.

In response to this:

Bug 1925408: Remove StatefulSet gatherer & replace it with gathering "cluster-mon…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.