Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1960546: Adds virt_platform metric to the collected metrics #427

Merged
merged 1 commit into from May 14, 2021
Merged

Bug 1960546: Adds virt_platform metric to the collected metrics #427

merged 1 commit into from May 14, 2021

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented May 14, 2021

Adds virt_platform metric to the collected metrics, this metric is present on every cluster, so testing can be done on a fresh cluster-bot cluster.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

  • docs/insights-archive-sample/config/metrics updated

Documentation

  • docs/gathered-data.md updated

Unit Tests

  • not necessary

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

References

@openshift-ci openshift-ci bot requested review from iNecas and natiiix May 14, 2021 07:34
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2021
@0sewa0 0sewa0 changed the title Adds virt_platform metric to the collected metrics Bug 1960546: Adds virt_platform metric to the collected metrics May 14, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label May 14, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 14, 2021

@0sewa0: This pull request references Bugzilla bug 1960546, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1960546: Adds virt_platform metric to the collected metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 14, 2021
@openshift-ci openshift-ci bot requested a review from psimovec May 14, 2021 07:40
natiiix
natiiix approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@natiiix natiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Seems like a simple addition, so I did not test this locally.
Nitpick: I noticed the indentation in the Go code was a bit off, but I'm not gonna re-run the CI just to fix a tiny thing like that, especially since the Markdown version is correctly indented.

@openshift-ci
Copy link

openshift-ci bot commented May 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, natiiix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit aedfd0a into openshift:master May 14, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 14, 2021

@0sewa0: All pull requests linked via external trackers have merged:

Bugzilla bug 1960546 has been moved to the MODIFIED state.

In response to this:

Bug 1960546: Adds virt_platform metric to the collected metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0sewa0 0sewa0 mentioned this pull request May 24, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natiiix natiiix natiiix approved these changes

@iNecas iNecas Awaiting requested review from iNecas

@psimovec psimovec Awaiting requested review from psimovec

Assignees

@natiiix natiiix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0sewa0 @openshift-bot @natiiix @openshift-merge-robot