Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2020250: Replacing deprecated ioutil #532

Merged

Conversation

rluders
Copy link
Contributor

@rluders rluders commented Nov 4, 2021

This PR replaces the deprecated ioutil as recommended by golang 1.16 changelog and makes our lint happy.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

n/a

Documentation

n/a

Unit Tests

n/a

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

n/a

References

https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???

@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from iNecas and mfojtik November 4, 2021 09:48
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021
@rluders rluders requested a review from tremes November 4, 2021 10:20
@rluders rluders changed the title Replacing deprecated ioutil Bug 2020250: Replacing deprecated ioutil Nov 4, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2021

@rluders: An error was encountered querying GitHub for users with public email (dmisharo@redhat.com) for bug 2020250 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2020250: Replacing deprecated ioutil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor

tremes commented Nov 4, 2021

Reviewed and looks reasonable. Thanks
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2021
@tremes
Copy link
Contributor

tremes commented Nov 4, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 4, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2021

@tremes: This pull request references Bugzilla bug 2020250, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dmisharo@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 771bed2 into openshift:master Nov 4, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2021

@rluders: All pull requests linked via external trackers have merged:

Bugzilla bug 2020250 has been moved to the MODIFIED state.

In response to this:

Bug 2020250: Replacing deprecated ioutil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tremes pushed a commit to tremes/insights-operator that referenced this pull request Nov 5, 2021
* refactor: replacing deprecated ioutil

* style: fixing lint issues

* fix: lint and error handling

* fix: govet err shadow declaration

* fix: ignore fileInfo error on prune
openshift-merge-robot pushed a commit that referenced this pull request Nov 11, 2021
…ation also in status (#536)

* [release-4.8] Bug 2020601: Anonymize the ImageRegistry storage information also in (#507)

* Bug 2005771: Anonymize the ImageRegistry storage information also in
status

* Update test

* Lint

* Replacing deprecated ioutil (#532)

* refactor: replacing deprecated ioutil

* style: fixing lint issues

* fix: lint and error handling

* fix: govet err shadow declaration

* fix: ignore fileInfo error on prune

Co-authored-by: Ricardo Lüders <rluders@redhat.com>
tremes pushed a commit to tremes/insights-operator that referenced this pull request Nov 25, 2021
* refactor: replacing deprecated ioutil

* style: fixing lint issues

* fix: lint and error handling

* fix: govet err shadow declaration

* fix: ignore fileInfo error on prune
openshift-merge-robot pushed a commit that referenced this pull request Nov 26, 2021
…namespaces of degraded clusteroperator (#553)

* [release-4.9] Bug 2026644: Gather all the container logs from related namespaces of degraded clusteroperator (#516)

* Bug 2020250: Replacing deprecated ioutil (#532)

* refactor: replacing deprecated ioutil

* style: fixing lint issues

* fix: lint and error handling

* fix: govet err shadow declaration

* fix: ignore fileInfo error on prune

Co-authored-by: Ricardo Lüders <rluders@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants