Console helm metrics #627
Console helm metrics #627
Conversation
|
Hi @Kartikey-star. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
Kartikey-star
force-pushed
the
console_helm_metrics
branch
from
8a39dd6
to
30fd488
Compare
|
/retest |
1 similar comment
|
/retest |
docs/gathered-data.md
Outdated
| @@ -524,6 +525,7 @@ Gathered metrics: | |||
| - "namespace:container_memory_usage_bytes:sum": 4.5+ | |||
| - "virt_platform metric": 4.6.34+, 4.7.16+, 4.8+ | |||
| - "vsphere_node_hw_version_total": 4.7.11+, 4.8+ | |||
| - "console_helm_installs_total": 4.10+ | |||
There was a problem hiding this comment.
4.10 GA is out so it should be 4.11+ (we should be able to make it)
There was a problem hiding this comment.
Ok so it cannot be backtracked is it..Like the operator will gather only the metrics for 4.11 ocp version onwards.
There was a problem hiding this comment.
It can be backported (we can discuss it once it's merged in master).
There was a problem hiding this comment.
Made the change for console_helm_installs_total ocp version to 4.11+
Signed-off-by: Kartikey Mamgain <mamgainkartikey@gmail.com>
Kartikey-star
force-pushed
the
console_helm_metrics
branch
from
30fd488
to
3a281af
Compare
|
/retest |
1 similar comment
|
/retest |
|
/approve |
|
Simple update and works as expected. Thanks. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kartikey-star, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@Kartikey-star: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label px-approved |
openshift-ci
bot
added
the
px-approved
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
We would like to add "console_helm_installs_total" metric created at the time of Installing a chart from Openshift Developer Console gathered by Insights Operator so that we can take decisions from that data. In order to achieve this i have modified gatherMostRecentMetrics method and updated the docs.
Categories
Sample Archive
path/to/sample_data.jsonDocumentation
docs/gathered-data.mdUnit Tests
path/to/file_test.goPrivacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
No
References