chore: renaming gather files #768

rluders · 2023-04-17T14:12:16Z

This PR renames the gather files to match gather method and prefix it with gather.

Sample Archive

N/A

Documentation

docs/gathered-data.md

Unit Tests

It also renames the test files to match the gather file.

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-10109
https://issues.redhat.com/browse/CCXDEV-10104
https://issues.redhat.com/browse/CCXDEV-10103
https://issues.redhat.com/browse/CCXDEV-10129

rluders · 2023-04-17T17:04:10Z

/retest

rluders · 2023-04-20T12:12:47Z

/retest

ncaak · 2023-04-25T16:11:38Z

This could backtrack to these Jira issues, as it partially solves them:

Also, could we take advantage on this PR and sort pkg/gatherers/clusterconfig/clusterconfig_gatherer.go gatheringFunctions function items? Maybe they're sorted in a way I cannot comprehend. But, if they're not, I could see some improvement if the items would be sorted alphabetically, instead chaotically.

rluders · 2023-04-25T18:22:56Z

@ncaak sorting the gathetingFunctions is actually a good idea. I'll update the PR.

rluders · 2023-06-01T08:12:49Z

I'm changing it for the draft, 'cause I'll include the unit tests for:

ClusterOperatos (already exists, I'm just double checking it)
ClusterAuthentication
TSBDStatus
FeatureGates

ncaak

/lgtm

ncaak

/lgtm

openshift-ci-robot · 2023-06-26T08:16:34Z

/retest-required

Remaining retests: 0 against base HEAD b69cebd and 2 for PR HEAD 665bfb4 in total

rluders · 2023-06-26T11:11:17Z

/override ci/prow/lint

openshift-ci · 2023-06-26T11:12:06Z

@rluders: Overrode contexts on behalf of rluders: ci/prow/lint

In response to this:

/override ci/prow/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rluders · 2023-06-26T11:13:33Z

/retest

pkg/gatherers/clusterconfig/clusterconfig_gatherer.go

…atus

…r_validating_webhook_configurations

ncaak

/lgtm

openshift-ci · 2023-06-28T14:53:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ncaak,rluders]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rluders · 2023-06-29T08:40:01Z

/override ci/prow/lint

openshift-ci · 2023-06-29T08:42:14Z

@rluders: Overrode contexts on behalf of rluders: ci/prow/lint

In response to this:

/override ci/prow/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rluders · 2023-06-29T08:54:02Z

/retest

JoaoFula · 2023-06-29T13:58:30Z

/label qe-approved

openshift-ci-robot · 2023-06-29T14:34:18Z

/retest-required

Remaining retests: 0 against base HEAD 8f64a40 and 2 for PR HEAD fd44e09 in total

rluders · 2023-06-30T11:43:28Z

/retest

openshift-ci · 2023-06-30T15:14:57Z

@rluders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

* chore(clusterconfig): rename authentications to gather_authentication * chore(clusterconfig): rename ceph_cluster to gather_cepth_cluster * chore(clusterconfig): rename certificate_signing_requests to gather_certificate_signing_requests * chore(clusterconfig): rename config_maps to gather_config_maps * chore(clusterconfig): rename container_images to gather_container_images * chore(clusterconfig): rename container_runtime_configs to gather_container_runtime_configs * chore(clusterconfig): rename cost_management_metrics_configs to gather_cost_management_metrics_configs * chore(clusterconfig): rename custom_resource_definitions to gather_custom_resource_definitions * chore(clusterconfig): rename dvo_metrics to gather_dvo_metrics * chore(clusterconfig): rename feature_gates to gather_feature_gates * chore(clusterconfig): rename host_subnets to gather_host_subnets * chore(clusterconfig): rename image to gather_cluster_image * chore(clusterconfig): rename image_pruners to gather_image_pruners * chore(clusterconfig): rename image_registries to gather_cluster_image_registries * chore(clusterconfig): rename install_plans to gather_install_plans * chore(clusterconfig): rename jaeger_cr to gather_jaeger_cr * chore(clusterconfig): rename machine_autoscalers to gather_machine_autoscalers * chore(clusterconfig): rename machine_config_pools to gather_machine_config_pools * chore(clusterconfig): rename machine_configs to gather_machine_configs * chore(clusterconfig): rename machine_healthchecks to gather_machine_health_check * chore(clusterconfig): rename machine_sets to gather_machine_sets * chore(clusterconfig): rename machines to gather_machines * chore(clusterconfig): rename mutatingwebhookconfigurations to gather_mutating_webhook_configurations * chore(clusterconfig): rename namespaces_with_overlapping_uids to gather_namespaces_with_overlapping_uids * chore(clusterconfig): rename netnamespace to gather_net_namespace * chore(clusterconfig): rename node_logs to gather_node_logs * chore(clusterconfig): rename olm_operators to gather_olm_operators * chore(clusterconfig): rename openshift_logging to gather_openshift_logging * chore(clusterconfig): rename openshift_machine_api_events to gather_openshift_machine_api_events * chore(clusterconfig): rename operators to gather_cluster_operators * chore(clusterconfig): rename operators_pods_and_events to gather_cluster_operator_pods_and_events * chore(clusterconfig): rename pod_disruption_budgets to gather_pod_disruption_budgets * chore(clusterconfig): rename pod_network_connectivity_checks to gather_pod_network_connectivity_checks * chore(clusterconfig): rename sap_config to gather_sap_config * chore(clusterconfig): rename sap_datahubs to gather_sap_datahubs * chore(clusterconfig): rename sap_pods to gather_sap_pods * chore(clusterconfig): rename scheduler to gather_schedulers * chore(clusterconfig): rename service_accounts to gather_service_accounts * chore(clusterconfig): rename storage_cluster to gather_storage_cluster * chore(clusterconfig): rename support_secret to gather_support_secret * chore(clusterconfig): rename tsdb_status to gather_prometheus_tsdb_status * chore(clusterconfig): rename validatingwebhookconfigurations to gather_validating_webhook_configurations * test(clusterconfig): adjusting method names * chore(workloads): rename workload_info to gather_workload_info * docs(gathered-data): update gathered-data docs * refactor: sort the gatherers for configcluster * test(clusterconfig): add tests for gather_cluster_feature_gates * test(clusterconfig): add tests for gather_cluster_authentication * test(clusterconfig): adds unit test for gather_prometheus_tsdb_status * fix: adding lost gatherers on merge

openshift-ci bot requested review from rhrmo and tremes April 17, 2023 14:13

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2023

rluders force-pushed the chore/renaming-gathers branch from 6ecea2c to 2af6808 Compare May 31, 2023 07:41

rluders marked this pull request as draft June 1, 2023 08:09

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2023

rluders force-pushed the chore/renaming-gathers branch from 2af6808 to 020d568 Compare June 17, 2023 13:34

rluders marked this pull request as ready for review June 20, 2023 10:46

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2023

openshift-ci bot requested a review from ncaak June 20, 2023 10:46

rluders force-pushed the chore/renaming-gathers branch from e79ee3d to 0629243 Compare June 22, 2023 07:40

ncaak approved these changes Jun 23, 2023

View reviewed changes

openshift-ci bot assigned ncaak Jun 23, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2023

rluders force-pushed the chore/renaming-gathers branch from 0629243 to 665bfb4 Compare June 26, 2023 07:36

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2023

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023

ncaak approved these changes Jun 26, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023

tremes reviewed Jun 26, 2023

View reviewed changes

pkg/gatherers/clusterconfig/clusterconfig_gatherer.go Show resolved Hide resolved

rluders added 15 commits June 27, 2023 09:45

chore(clusterconfig): rename sap_pods to gather_sap_pods

fb8e6a6

chore(clusterconfig): rename scheduler to gather_schedulers

2f4ec00

chore(clusterconfig): rename service_accounts to gather_service_accounts

240f461

chore(clusterconfig): rename storage_cluster to gather_storage_cluster

1d52a7c

chore(clusterconfig): rename support_secret to gather_support_secret

720899d

chore(clusterconfig): rename tsdb_status to gather_prometheus_tsdb_st…

33f24a8

…atus

chore(clusterconfig): rename validatingwebhookconfigurations to gathe…

7a3871e

…r_validating_webhook_configurations

test(clusterconfig): adjusting method names

d47e572

chore(workloads): rename workload_info to gather_workload_info

285f91c

docs(gathered-data): update gathered-data docs

fc75d52

refactor: sort the gatherers for configcluster

c54d8e4

test(clusterconfig): add tests for gather_cluster_feature_gates

4174040

test(clusterconfig): add tests for gather_cluster_authentication

dd76bbd

test(clusterconfig): adds unit test for gather_prometheus_tsdb_status

220b377

fix: adding lost gatherers on merge

fd44e09

rluders force-pushed the chore/renaming-gathers branch from 665bfb4 to fd44e09 Compare June 27, 2023 07:45

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2023

ncaak approved these changes Jun 28, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 29, 2023

openshift-merge-robot merged commit d88e43c into openshift:master Jun 30, 2023
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: renaming gather files #768

chore: renaming gather files #768

rluders commented Apr 17, 2023 •

edited

rluders commented Apr 17, 2023

rluders commented Apr 20, 2023

ncaak commented Apr 25, 2023

rluders commented Apr 25, 2023

rluders commented Jun 1, 2023

ncaak left a comment

ncaak left a comment

openshift-ci-robot commented Jun 26, 2023

rluders commented Jun 26, 2023

openshift-ci bot commented Jun 26, 2023

rluders commented Jun 26, 2023

ncaak left a comment

openshift-ci bot commented Jun 28, 2023

rluders commented Jun 29, 2023

openshift-ci bot commented Jun 29, 2023

rluders commented Jun 29, 2023

JoaoFula commented Jun 29, 2023

openshift-ci-robot commented Jun 29, 2023

rluders commented Jun 30, 2023

openshift-ci bot commented Jun 30, 2023

chore: renaming gather files #768

chore: renaming gather files #768

Conversation

rluders commented Apr 17, 2023 • edited

Categories

Sample Archive

Documentation

Unit Tests

Privacy

Changelog

Breaking Changes

References

rluders commented Apr 17, 2023

rluders commented Apr 20, 2023

ncaak commented Apr 25, 2023

rluders commented Apr 25, 2023

rluders commented Jun 1, 2023

ncaak left a comment

Choose a reason for hiding this comment

ncaak left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Jun 26, 2023

rluders commented Jun 26, 2023

openshift-ci bot commented Jun 26, 2023

rluders commented Jun 26, 2023

ncaak left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jun 28, 2023

rluders commented Jun 29, 2023

openshift-ci bot commented Jun 29, 2023

rluders commented Jun 29, 2023

JoaoFula commented Jun 29, 2023

openshift-ci-robot commented Jun 29, 2023

rluders commented Jun 30, 2023

openshift-ci bot commented Jun 30, 2023

rluders commented Apr 17, 2023 •

edited