Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-7871: Collect info about monitoring pods pv #769

Merged
merged 5 commits into from May 4, 2023
Merged

[release-4.12] OCPBUGS-7871: Collect info about monitoring pods pv #769

merged 5 commits into from May 4, 2023

Conversation

ncaak
Copy link
Contributor

@ncaak ncaak commented Apr 17, 2023

This PR implements Persistent Volumes gathering from openshift-monitoring namespace. It's a backport from 4.14.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/persistentvolumes/monitoring-persistent-volume.json

Documentation

  • docs/gathered-data.md#monitoringpvs

Unit Tests

  • /pkg/gatherers/clusterconfig/gather_monitoring_pvs_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Yes

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-10221
https://issues.redhat.com/browse/OCPBUGS-7871

@openshift-ci
Copy link

openshift-ci bot commented Apr 17, 2023

@ncaak: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-7871: Collect info about monitoring pods pv

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 17, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

@ncaak: This pull request references Jira Issue OCPBUGS-7871, which is invalid:

  • expected dependent Jira Issue OCPBUGS-8243 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR implements Persistent Volumes gathering from openshift-monitoring namespace. It's a backport from 4.14.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/persistentvolumes/monitoring-persistent-volume.json

Documentation

  • docs/gathered-data.md#monitoringpvs

Unit Tests

  • /pkg/gatherers/clusterconfig/gather_monitoring_pvs_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Yes

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-10221
https://issues.redhat.com/browse/OCPBUGS-7871

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Apr 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2023
@ncaak
Copy link
Contributor Author

ncaak commented Apr 17, 2023

/test lint

@ncaak
Copy link
Contributor Author

ncaak commented Apr 18, 2023

/test lint

@ncaak ncaak marked this pull request as ready for review April 18, 2023 07:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2023
@openshift-ci openshift-ci bot requested review from rhrmo and rluders April 18, 2023 07:58
@ncaak
Copy link
Contributor Author

ncaak commented Apr 18, 2023

/test insights-operator-e2e-tests

@tremes
Copy link
Contributor

tremes commented Apr 18, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 18, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 18, 2023

@ncaak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ncaak
Copy link
Contributor Author

ncaak commented Apr 19, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 19, 2023
@openshift-ci-robot
Copy link
Contributor

@ncaak: This pull request references Jira Issue OCPBUGS-7871, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-8243 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-8243 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 19, 2023
@openshift-ci openshift-ci bot requested a review from JoaoFula April 19, 2023 10:44
@tremes
Copy link
Contributor

tremes commented May 4, 2023

There are some unnecessary changes, such as the CHANGELOG update and the service_accounts_test.go update, but they don't hurt and should not break anything.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2023
@JoaoFula
Copy link
Contributor

JoaoFula commented May 4, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6ebf808 into openshift:release-4.12 May 4, 2023
7 checks passed
@openshift-ci-robot
Copy link
Contributor

@ncaak: Jira Issue OCPBUGS-7871: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-7871 has been moved to the MODIFIED state.

In response to this:

This PR implements Persistent Volumes gathering from openshift-monitoring namespace. It's a backport from 4.14.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/persistentvolumes/monitoring-persistent-volume.json

Documentation

  • docs/gathered-data.md#monitoringpvs

Unit Tests

  • /pkg/gatherers/clusterconfig/gather_monitoring_pvs_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Yes

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-10221
https://issues.redhat.com/browse/OCPBUGS-7871

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.12.0-0.nightly-2023-05-05-162250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhrmo rhrmo Awaiting requested review from rhrmo

@rluders rluders Awaiting requested review from rluders

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ncaak @openshift-ci-robot @tremes @JoaoFula @openshift-merge-robot