Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DataGather status conditions and status propagation #805

Merged
merged 4 commits into from Jul 11, 2023
Merged

Implement DataGather status conditions and status propagation #805

merged 4 commits into from Jul 11, 2023

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Jun 28, 2023 •
edited

TechPreview only
This implements the status conditions for the new CRD/CR datagather.insights.openshift.io. The CRs will have two basic conditions:

  • DataRecorded - tells whether the Insights data was recorded correctly or not
  • DataUploaded - tells whether the Insights data was uploaded or not
    The status of the last datagather is propagated/copied into the insightsoperator.operator.openshift.io cluster CR.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

no new data

Documentation

Unit Tests

  • pkg/controller/periodic/periodic_test.go - extended

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot requested review from rhrmo and rluders June 28, 2023 08:21
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
ncaak
ncaak approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoaoFula
Copy link
Contributor

Found one issue but will report it separately. Approving.

@JoaoFula
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 10, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0f38b40 and 2 for PR HEAD 81b59f1 in total

@tremes
Copy link
Contributor Author

tremes commented Jul 11, 2023

/retest

@tremes
Copy link
Contributor Author

tremes commented Jul 11, 2023

/override ci/prow/e2e-gcp-ovn-techpreview

@tremes
Copy link
Contributor Author

tremes commented Jul 11, 2023

/test insights-operator-e2e-tests

@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-gcp-ovn-techpreview

In response to this:

/override ci/prow/e2e-gcp-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Jul 11, 2023

/test insights-operator-e2e-tests

@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2023

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 37673b1 into openshift:master Jul 11, 2023
8 of 9 checks passed
@tremes tremes deleted the gather-job-tp-status-rebased branch July 27, 2023 07:18
JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
@tremes @JoaoFula
Implement DataGather status conditions and status propagation (opensh…
11c54de 
…ift#805)

* Implement DataGather status conditions

* propagate status to clusteroperator status

* propagate the failed job to the original status controller

* Improve as suggested in review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncaak ncaak ncaak approved these changes

@rhrmo rhrmo Awaiting requested review from rhrmo

@rluders rluders Awaiting requested review from rluders

Assignees

@ncaak ncaak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tremes @JoaoFula @openshift-ci-robot @ncaak @openshift-merge-robot