Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-20034: improve on-demand data gathering timing issues #832

Merged
merged 1 commit into from Oct 13, 2023
Merged

OCPBUGS-20034: improve on-demand data gathering timing issues #832

merged 1 commit into from Oct 13, 2023

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Oct 3, 2023

This extracts the "listener" for the on-demand data gathering requests/resources to separate function. Why should this be better than the previous solution?

  • the periodic data gathering doesn't block (when running) the on-demand data gathering requests
  • new context is created only when a new valid dataGather resource is created - this used to have unexpected consequences - e.g the on-demand datagathering request didn't work because the context was already timeout

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • no new data gathered

Documentation

Unit Tests

  • simple unit test added, but it will be better to test in the integration tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-20034
https://access.redhat.com/solutions/???

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 3, 2023
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Jira Issue OCPBUGS-20034, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This extracts the "listener" for the on-demand data gathering requests/resources to separate function. Why should this be better than the previous solution?

  • the periodic data gathering doesn't block (when running) the on-demand data gathering requests
  • new context is created only when a new valid dataGather resource is created - this used to have unexpected consequences - e.g the on-demand datagathering request didn't work because the context was already timeout

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • no new data gathered

Documentation

Unit Tests

  • simple unit test added, but it will be better to test in the integration tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-20034
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Jira Issue OCPBUGS-20034, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

This extracts the "listener" for the on-demand data gathering requests/resources to separate function. Why should this be better than the previous solution?

  • the periodic data gathering doesn't block (when running) the on-demand data gathering requests
  • new context is created only when a new valid dataGather resource is created - this used to have unexpected consequences - e.g the on-demand datagathering request didn't work because the context was already timeout

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • no new data gathered

Documentation

Unit Tests

  • simple unit test added, but it will be better to test in the integration tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-20034
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@tremes
Copy link
Contributor Author

tremes commented Oct 4, 2023

/retest

@JoaoFula
Copy link
Contributor

JoaoFula commented Oct 4, 2023

Verification is on my side RN. Will provide qe-approved label only after verification due to broken qe-approved/OCPBUGS process (see OCPCRT-268)

ncaak
ncaak approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tremes
Copy link
Contributor Author

tremes commented Oct 4, 2023

/retest

@tremes
Copy link
Contributor Author

tremes commented Oct 4, 2023

/test e2e-gcp-ovn-techpreview

2 similar comments
@tremes
Copy link
Contributor Author

tremes commented Oct 9, 2023

/test e2e-gcp-ovn-techpreview

@tremes
Copy link
Contributor Author

tremes commented Oct 9, 2023

/test e2e-gcp-ovn-techpreview

@JoaoFula
Copy link
Contributor

JoaoFula commented Oct 9, 2023

/check-required-labels

1 similar comment
@tremes
Copy link
Contributor Author

tremes commented Oct 9, 2023

/check-required-labels

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4969600 and 2 for PR HEAD 33bf389 in total

@tremes
Copy link
Contributor Author

tremes commented Oct 10, 2023

/retest

2 similar comments
@tremes
Copy link
Contributor Author

tremes commented Oct 10, 2023

/retest

@tremes
Copy link
Contributor Author

tremes commented Oct 11, 2023

/retest

@tremes
Copy link
Contributor Author

tremes commented Oct 11, 2023

/test e2e-gcp-ovn-techpreview

1 similar comment
@tremes
Copy link
Contributor Author

tremes commented Oct 11, 2023

/test e2e-gcp-ovn-techpreview

@tremes
Copy link
Contributor Author

tremes commented Oct 12, 2023

/test insights-operator-e2e-tests

2 similar comments
@tremes
Copy link
Contributor Author

tremes commented Oct 12, 2023

/test insights-operator-e2e-tests

@tremes
Copy link
Contributor Author

tremes commented Oct 13, 2023

/test insights-operator-e2e-tests

@tremes
Copy link
Contributor Author

tremes commented Oct 13, 2023

We have some flaky and unrelated tests. Overriding for now
/override ci/prow/insights-operator-e2e-tests

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/insights-operator-e2e-tests

In response to this:

We have some flaky and unrelated tests. Overriding for now
/override ci/prow/insights-operator-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 1bff8d0 into openshift:master Oct 13, 2023
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@tremes: Jira Issue OCPBUGS-20034: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20034 has been moved to the MODIFIED state.

In response to this:

This extracts the "listener" for the on-demand data gathering requests/resources to separate function. Why should this be better than the previous solution?

  • the periodic data gathering doesn't block (when running) the on-demand data gathering requests
  • new context is created only when a new valid dataGather resource is created - this used to have unexpected consequences - e.g the on-demand datagathering request didn't work because the context was already timeout

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • no new data gathered

Documentation

Unit Tests

  • simple unit test added, but it will be better to test in the integration tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-20034
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Oct 13, 2023

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@tremes: new pull request created: #835

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 13, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-10-17-065657

JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
@tremes @JoaoFula
OCPBUGS-20034: improve on-demand data gathering timing issues (opensh…
9687d9b 
…ift#832)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncaak ncaak ncaak approved these changes

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

@rhrmo rhrmo Awaiting requested review from rhrmo

@rluders rluders Awaiting requested review from rluders

Assignees

@ncaak ncaak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tremes @openshift-ci-robot @JoaoFula @openshift-cherrypick-robot @openshift-merge-robot @ncaak