Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-23097: DVO gatherer - do the retry request as HEAD and not stream #861

Merged
merged 1 commit into from Nov 9, 2023

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Nov 9, 2023

This updates the original queryMetricsService function in the DVO gatherer. I think the problem was that the timeout for the context was only 5 seconds and this context was also used for streaming the data. 5 seconds is not enough when streaming larger DVO metrics data.

This changes the logic to use HEAD request to check whether the DVO service is up and running and then, if it's OK, start reading/streaming the data.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • path/to/sample_data.json

Documentation

  • path/to/documentation.md

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot requested review from ncaak and rluders November 9, 2023 07:14
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2023
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2023
Copy link

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tremes tremes changed the title DVO gatherer - do the retry request as HEAD and not stream OCPBUGS-23097: DVO gatherer - do the retry request as HEAD and not stream Nov 9, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 9, 2023
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Jira Issue OCPBUGS-23097, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This updates the original queryMetricsService function in the DVO gatherer. I think the problem was that the timeout for the context was only 5 seconds and this context was also used for streaming the data. 5 seconds is not enough when streaming larger DVO metrics data.

This changes the logic to use HEAD request to check whether the DVO service is up and running and then, if it's OK, start reading/streaming the data.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • path/to/sample_data.json

Documentation

  • path/to/documentation.md

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from JoaoFula November 9, 2023 09:16
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 249263c and 2 for PR HEAD e94a97b in total

@tremes
Copy link
Contributor Author

tremes commented Nov 9, 2023

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Copy link

openshift-ci bot commented Nov 9, 2023

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Nov 9, 2023

/retest

Copy link

openshift-ci bot commented Nov 9, 2023

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 60fcf31 into openshift:master Nov 9, 2023
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@tremes: Jira Issue OCPBUGS-23097: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23097 has been moved to the MODIFIED state.

In response to this:

This updates the original queryMetricsService function in the DVO gatherer. I think the problem was that the timeout for the context was only 5 seconds and this context was also used for streaming the data. 5 seconds is not enough when streaming larger DVO metrics data.

This changes the logic to use HEAD request to check whether the DVO service is up and running and then, if it's OK, start reading/streaming the data.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • path/to/sample_data.json

Documentation

  • path/to/documentation.md

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tremes added a commit to tremes/insights-operator that referenced this pull request Nov 20, 2023
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.15.0-202311202349.p0.g60fcf31.assembly.stream for distgit ose-insights-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants