Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCXDEV-12194: read configmap during configmap observer init #864

Merged
merged 2 commits into from Nov 27, 2023

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Nov 14, 2023

This is adding the logic to try to read the new configuration config map immediately during the configmap observer initialization (and not wait for the first informer sync or re-sync)

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

no new data

Documentation

  • path/to/documentation.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2023
@openshift-ci openshift-ci bot requested review from ncaak and rhrmo November 14, 2023 11:52
Copy link

openshift-ci bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2023
@tremes tremes changed the title WIP read configmap during configmap observer init CCXDEV-12914 read configmap during configmap observer init Nov 14, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2023
@JoaoFula
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 14, 2023
Copy link

openshift-ci bot commented Nov 14, 2023

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rluders
Copy link
Contributor

rluders commented Nov 20, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
@tremes tremes changed the title CCXDEV-12914 read configmap during configmap observer init CCXDEV-12194: read configmap during configmap observer init Nov 20, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 20, 2023

@tremes: This pull request references CCXDEV-12194 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

This is adding the logic to try to read the new configuration config map immediately during the configmap observer initialization (and not wait for the first informer sync or re-sync)

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

no new data

Documentation

  • path/to/documentation.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f440fa0 into openshift:master Nov 27, 2023
9 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.15.0-202311272131.p0.gf440fa0.assembly.stream for distgit ose-insights-operator.
All builds following this will include this PR.

rluders pushed a commit to rluders/insights-operator that referenced this pull request Nov 29, 2023
…t#864)

* read configmap during configmap observer init

* fix logging
JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
…t#864)

* read configmap during configmap observer init

* fix logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants