Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: fix errors handling + docs + lint #866

Merged
merged 3 commits into from
Dec 11, 2023
Merged

NO-JIRA: fix errors handling + docs + lint #866

merged 3 commits into from
Dec 11, 2023

Conversation

rluders
Copy link
Contributor

@rluders rluders commented Nov 15, 2023

This PR fixes some code issues related to documentation and error comparison.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

n/a

Documentation

n/a

Unit Tests

n/a

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot requested review from rhrmo and tremes November 15, 2023 13:42
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@rluders rluders force-pushed the fix/recommended-error-comparasion branch from 9f0683c to f10e60b Compare November 16, 2023 12:21
@rluders
Copy link
Contributor Author

rluders commented Nov 20, 2023

/retest

@rluders rluders changed the title fix: errors handling + docs + lint NO-JIRA: fix errors handling + docs + lint Nov 29, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 29, 2023
@openshift-ci-robot
Copy link
Contributor

@rluders: This pull request explicitly references no jira issue.

In response to this:

This PR fixes some code issues related to documentation and error comparison.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

n/a

Documentation

n/a

Unit Tests

n/a

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor

tremes commented Dec 6, 2023

Minor changes
/lgtm
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 6, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 54b8396 and 2 for PR HEAD f10e60b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2e6175f and 1 for PR HEAD f10e60b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d1f4557 and 0 for PR HEAD f10e60b in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision f10e60b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023
@rluders
Copy link
Contributor Author

rluders commented Dec 8, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d1f4557 and 2 for PR HEAD f10e60b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a8a80ec and 1 for PR HEAD f10e60b in total

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 11, 2023

@rluders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b3cd2de into openshift:master Dec 11, 2023
9 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.16.0-202312111513.p0.gb3cd2de.assembly.stream for distgit ose-insights-operator.
All builds following this will include this PR.

rluders pushed a commit to rluders/insights-operator that referenced this pull request Dec 12, 2023
NO-JIRA: fix errors handling + docs + lint (openshift#866)
fac3214 
* fix: direct comparison of errors

* style: fix comments and nolint

* style: nolint oauth misspell
JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
@JoaoFula
NO-JIRA: fix errors handling + docs + lint (openshift#866)
78b8efa 
* fix: direct comparison of errors

* style: fix comments and nolint

* style: nolint oauth misspell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhrmo rhrmo Awaiting requested review from rhrmo

@tremes tremes Awaiting requested review from tremes

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rluders @openshift-ci-robot @tremes @openshift-bot