Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: fix helmchart gather unit test #880

Merged
merged 2 commits into from Jan 23, 2024
Merged

NO-JIRA: fix helmchart gather unit test #880

merged 2 commits into from Jan 23, 2024

Conversation

rluders
Copy link
Contributor

@rluders rluders commented Dec 5, 2023

This PR fixes some inconsistency at the Helm chart gatherer unit tests (comparing unsorted map).

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • path/to/sample_data.json

Documentation

  • path/to/documentation.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot requested review from ncaak and tremes December 5, 2023 12:41
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@tremes
Copy link
Contributor

tremes commented Dec 5, 2023

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 5, 2023
tremes
tremes reviewed Dec 6, 2023
View reviewed changes
docs/gathered-data.md Outdated Show resolved Hide resolved
@rluders rluders requested a review from tremes December 6, 2023 10:19
@tremes
Copy link
Contributor

tremes commented Dec 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
@rluders
Copy link
Contributor Author

rluders commented Dec 7, 2023

/retest

@rluders rluders changed the title test: fix helmchart gather unit test NO-JIRA: fix helmchart gather unit test Dec 8, 2023
@openshift-ci-robot
Copy link
Contributor

@rluders: This pull request explicitly references no jira issue.

In response to this:

This PR fixes some inconsistency at the Helm chart gatherer unit tests (comparing unsorted map).

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • path/to/sample_data.json

Documentation

  • path/to/documentation.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 8, 2023
@tremes
Copy link
Contributor

tremes commented Dec 8, 2023

/test insights-operator-e2e-tests

1 similar comment
@tremes
Copy link
Contributor

tremes commented Dec 15, 2023

/test insights-operator-e2e-tests

@rluders
Copy link
Contributor Author

rluders commented Dec 21, 2023

/retest

@tremes
Copy link
Contributor

tremes commented Jan 3, 2024

/test insights-operator-e2e-tests

5 similar comments
@tremes
Copy link
Contributor

tremes commented Jan 4, 2024

/test insights-operator-e2e-tests

@tremes
Copy link
Contributor

tremes commented Jan 15, 2024

/test insights-operator-e2e-tests

@tremes
Copy link
Contributor

tremes commented Jan 19, 2024

/test insights-operator-e2e-tests

@tremes
Copy link
Contributor

tremes commented Jan 22, 2024

/test insights-operator-e2e-tests

@tremes
Copy link
Contributor

tremes commented Jan 22, 2024

/test insights-operator-e2e-tests

@JoaoFula
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 23, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6fc5127 and 2 for PR HEAD eafae76 in total

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 23, 2024

@rluders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 226e253 into openshift:master Jan 23, 2024
9 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.16.0-202401231834.p0.g226e253.assembly.stream for distgit ose-insights-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncaak ncaak Awaiting requested review from ncaak

@tremes tremes Awaiting requested review from tremes

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rluders @tremes @openshift-ci-robot @JoaoFula @openshift-bot