Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: (refactor) reduce cognitive and adding unit tests #889

Merged
merged 4 commits into from Mar 27, 2024
Merged

NO-JIRA: (refactor) reduce cognitive and adding unit tests #889

merged 4 commits into from Mar 27, 2024

Conversation

rluders
Copy link
Contributor

@rluders rluders commented Dec 20, 2023

This PR implements a new data enhancement to...

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • path/to/sample_data.json

Documentation

  • path/to/documentation.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot requested review from ncaak and tremes December 20, 2023 09:08
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2023
ncaak
ncaak approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
@rluders
Copy link
Contributor Author

rluders commented Dec 20, 2023

/test unit

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
@rluders
Copy link
Contributor Author

rluders commented Feb 10, 2024

/retest

1 similar comment
@rluders
Copy link
Contributor Author

rluders commented Feb 21, 2024

/retest

@rluders rluders changed the title refactor/reduce cognitive and adding unit tests NO-JIRA: (refactor) reduce cognitive and adding unit tests Feb 26, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2024
@openshift-ci-robot
Copy link
Contributor

@rluders: This pull request explicitly references no jira issue.

In response to this:

This PR implements a new data enhancement to...

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • path/to/sample_data.json

Documentation

  • path/to/documentation.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ncaak
ncaak approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rluders
Copy link
Contributor Author

rluders commented Mar 27, 2024

@JoaoFula

@JoaoFula
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 27, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2bb7e46 and 2 for PR HEAD 93faeb0 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 363c3b1 and 1 for PR HEAD 93faeb0 in total

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 27, 2024

@rluders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a836d6c into openshift:master Mar 27, 2024
9 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.16.0-202403280418.p0.ga836d6c.assembly.stream.el9 for distgit ose-insights-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncaak ncaak ncaak approved these changes

@tremes tremes Awaiting requested review from tremes

Assignees

@ncaak ncaak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rluders @openshift-ci-robot @JoaoFula @openshift-bot @ncaak