New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.12] OCPBUGS-24256: adds helm information gather #890
[release-4.12] OCPBUGS-24256: adds helm information gather #890
Conversation
* feat: gather helm information * feat(gather/hemlchart_info): add resource counter * docs: adds helmchart_info sample data * test: adds some unit test for helmchart_gather * test: expanding gather_helm_info tests * feat: adding helmchart gatherer * docs: update gathered-data * Revert "feat: adding helmchart gatherer" This reverts commit e57a5c1. * refactor: revert helmcharts gatherer * style: fix lint errors * refactor(helm_info): remove if for label checking * refactor(gather_info): unexpose labelChartNameKey const * fix: wrong log message * test(helm_gather_info): invalid resources
@rluders: This pull request references Jira Issue OCPBUGS-24256, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label cherry-pick-approved |
/override lint |
@rluders: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/lint |
@rluders: Overrode contexts on behalf of rluders: ci/prow/lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncaak, rluders The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@rluders: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test e2e-agnostic-upgrade |
/label backport-risk-assessed |
e69d628
into
openshift:release-4.12
@rluders: Jira Issue OCPBUGS-24256: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-24256 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-insights-operator-container-v4.12.0-202401021051.p0.ge69d628.assembly.stream for distgit ose-insights-operator. |
Backport #868
Categories
Sample Archive
docs/insights-archive-sample/config/helmchart_info.json
Documentation
docs/gathered-data.md
(updated)Unit Tests
pkg/gatherers/workloads/gather_helm_info_test.go
pkg/gatherers/workloads/gather_workloads_info_test.go
(updated)pkg/gatherers/workloads/types_test.go
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
No
References
https://issues.redhat.com/browse/CCXDEV-12266