Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.12] OCPBUGS-24256: adds helm information gather #890

Conversation

rluders
Copy link
Contributor

@rluders rluders commented Dec 20, 2023

Backport #868

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/helmchart_info.json

Documentation

  • docs/gathered-data.md (updated)

Unit Tests

  • pkg/gatherers/workloads/gather_helm_info_test.go
  • pkg/gatherers/workloads/gather_workloads_info_test.go (updated)
  • pkg/gatherers/workloads/types_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-12266

* feat: gather helm information

* feat(gather/hemlchart_info): add resource counter

* docs: adds helmchart_info sample data

* test: adds some unit test for helmchart_gather

* test: expanding gather_helm_info tests

* feat: adding helmchart gatherer

* docs: update gathered-data

* Revert "feat: adding helmchart gatherer"

This reverts commit e57a5c1.

* refactor: revert helmcharts gatherer

* style: fix lint errors

* refactor(helm_info): remove if for label checking

* refactor(gather_info): unexpose labelChartNameKey const

* fix: wrong log message

* test(helm_gather_info): invalid resources
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 20, 2023
@openshift-ci-robot
Copy link
Contributor

@rluders: This pull request references Jira Issue OCPBUGS-24256, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-24255 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-24255 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @JoaoFula

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport #868

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/helmchart_info.json

Documentation

  • docs/gathered-data.md (updated)

Unit Tests

  • pkg/gatherers/workloads/gather_helm_info_test.go
  • pkg/gatherers/workloads/gather_workloads_info_test.go (updated)
  • pkg/gatherers/workloads/types_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-12266

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2023
@JoaoFula
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 20, 2023
@rluders
Copy link
Contributor Author

rluders commented Dec 20, 2023

/override lint

Copy link

openshift-ci bot commented Dec 20, 2023

@rluders: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • lint

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e
  • ci/prow/e2e-agnostic-upgrade
  • ci/prow/images
  • ci/prow/insights-operator-e2e-tests
  • ci/prow/lint
  • ci/prow/unit
  • pull-ci-openshift-insights-operator-master-e2e
  • pull-ci-openshift-insights-operator-master-e2e-agnostic-upgrade
  • pull-ci-openshift-insights-operator-master-images
  • pull-ci-openshift-insights-operator-master-insights-operator-e2e-tests
  • pull-ci-openshift-insights-operator-master-lint
  • pull-ci-openshift-insights-operator-master-unit
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rluders
Copy link
Contributor Author

rluders commented Dec 20, 2023

/override ci/prow/lint

Copy link

openshift-ci bot commented Dec 20, 2023

@rluders: Overrode contexts on behalf of rluders: ci/prow/lint

In response to this:

/override ci/prow/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
Copy link

openshift-ci bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rluders
Copy link
Contributor Author

rluders commented Dec 21, 2023

/retest

Copy link

openshift-ci bot commented Dec 21, 2023

@rluders: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint 7435ebe link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tremes
Copy link
Contributor

tremes commented Jan 2, 2024

/test e2e-agnostic-upgrade

@tremes
Copy link
Contributor

tremes commented Jan 2, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e69d628 into openshift:release-4.12 Jan 2, 2024
7 checks passed
@openshift-ci-robot
Copy link
Contributor

@rluders: Jira Issue OCPBUGS-24256: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24256 has been moved to the MODIFIED state.

In response to this:

Backport #868

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/helmchart_info.json

Documentation

  • docs/gathered-data.md (updated)

Unit Tests

  • pkg/gatherers/workloads/gather_helm_info_test.go
  • pkg/gatherers/workloads/gather_workloads_info_test.go (updated)
  • pkg/gatherers/workloads/types_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-12266

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.12.0-202401021051.p0.ge69d628.assembly.stream for distgit ose-insights-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants