OpenStack: Read cloud names from other locations

Now we read clouds only from clouds.yaml file, but there are two
other possible locations: clouds-public.yaml and secure.yaml

This patch appends clouds from those files to the list of available
clouds.

Fixes: #2997

pkg/asset/installconfig/openstack/realvalidvaluesfetcher.go

@@ -21,13 +21,33 @@ func NewValidValuesFetcher() validation.ValidValuesFetcher {
 	return realValidValuesFetcher{}
 }
 
-// GetCloudNames gets the valid cloud names. These are read from clouds.yaml.
+// GetCloudNames gets the valid cloud names. These are read from clouds.yaml,
+// clouds-public.yaml and secure.yaml.
 func (f realValidValuesFetcher) GetCloudNames() ([]string, error) {
+	// Read data from clouds.yaml
 	clouds, err := new(yamlLoadOpts).LoadCloudsYAML()
 	if err != nil {
 		return nil, err
 	}
 
+	// Read data from clouds-public.yaml and append it to clouds
+	publicClouds, err := new(yamlLoadOpts).LoadPublicCloudsYAML()
+	if err != nil {
+		return nil, err
+	}
+	for k, v := range publicClouds {
+		clouds[k] = v
+	}
+
+	// Read data from secure.yaml and append it to clouds
+	secureClouds, err := new(yamlLoadOpts).LoadSecureCloudsYAML()
+	if err != nil {
+		return nil, err
+	}
+	for k, v := range secureClouds {
+		clouds[k] = v
+	}
+
 	i := 0
 	cloudNames := make([]string, len(clouds))
 	for k := range clouds {