Skip to content

Commit

Permalink
do not generate the cloud cred secret when credentialsMode is Manual
Browse files Browse the repository at this point in the history
Indicating mode "Manual" means the user will be responsible for administering credentials to the components that need them.
And "Manual" mode can be used to install using temporary credentials (for AWS) for which there is no reason to place temporary credentials into the cluster that will never be updated.
  • Loading branch information
Joel Diaz committed Dec 2, 2020
1 parent ee4ddcf commit 6908fb9
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/asset/manifests/openshift.go
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,9 @@ func (o *Openshift) Generate(dependencies asset.Parents) error {

switch platform {
case awstypes.Name, openstacktypes.Name, vspheretypes.Name, azuretypes.Name, gcptypes.Name, ovirttypes.Name:
assetData["99_cloud-creds-secret.yaml"] = applyTemplateData(cloudCredsSecret.Files()[0].Data, templateData)
if installConfig.Config.CredentialsMode != types.ManualCredentialsMode {
assetData["99_cloud-creds-secret.yaml"] = applyTemplateData(cloudCredsSecret.Files()[0].Data, templateData)
}
assetData["99_role-cloud-creds-secret-reader.yaml"] = applyTemplateData(roleCloudCredsSecretReader.Files()[0].Data, templateData)
case baremetaltypes.Name:
bmTemplateData := baremetalTemplateData{
Expand Down

0 comments on commit 6908fb9

Please sign in to comment.