Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Rafael F. <r4f4rfs@gmail.com>
  • Loading branch information
bharath-b-rh and r4f4 committed Jan 31, 2024
1 parent f01b5a4 commit c1a0d27
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/asset/cluster/tfvars/tfvars.go
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ func (t *TerraformVariables) Generate(parents asset.Parents) error {

tags, err := gcpconfig.GetUserTags(gcpconfig.NewTagManager(client), installConfig.Config)
if err != nil {
return errors.Wrapf(err, "failed to fetch user-defined tags")
return fmt.Errorf("failed to fetch user-defined tags: %w", err)
}

data, err := gcptfvars.TFVars(
Expand Down
2 changes: 1 addition & 1 deletion pkg/asset/installconfig/gcp/usertags.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ func validateAndStoreUserTags(ctx context.Context, mgr TagManager, project strin
func getProjectTags(ctx context.Context, mgr TagManager, project string) (effectiveTags, error) {
client, err := getTagBindingsClient(ctx, mgr)
if err != nil {
return nil, errors.Wrapf(err, "failed to create client to fetch effective tags on the %s project", project)
return nil, fmt.Errorf("failed to create client to fetch effective tags on the %s project: %w", project, err)
}
defer client.Close()

Expand Down

0 comments on commit c1a0d27

Please sign in to comment.