Skip to content

Commit

Permalink
additionalTrustBundle IsCA check to warn instead of drop
Browse files Browse the repository at this point in the history
When using `additionalTrustBundle` accept v1 certificates and non-CA
certificates. In place of the drop warn user that the
certificate provided is either v1 or a non-CA certificate.
  • Loading branch information
jcpowermac committed Feb 25, 2020
1 parent 1b1cc3c commit e645f96
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/asset/manifests/additionaltrustbundleconfig.go
Expand Up @@ -115,9 +115,11 @@ func parseCertificates(certificates string) (map[string]string, error) {
}

if cert.IsCA {
sb.WriteString(string(pem.EncodeToMemory(block)))
logrus.Warn("The additionalTrustBundle certificate is either not v3 or a certificate authority")
}

sb.WriteString(string(pem.EncodeToMemory(block)))

if len(rest) == 0 {
break
}
Expand Down

0 comments on commit e645f96

Please sign in to comment.