RFE: add versioning to pull-secret file and check at installer

[davivcgarcia]

Version

$ ./openshift-install version
./openshift-install v0.13.0

Platform (aws|libvirt|openstack):

AWS

What happened?

I've been testing openshift-installer since version v0.8.0, using the same pull-secret.txt that I downloaded at that time. Due #1320, i discovered that the schema for the pull-secret has changed to include more authentication credentials.

What you expected to happen?

We should start versioning the pull-secret, so the openshift-installer could start checking if the file reflects the last schema and expected content. As an example, the file should look like:

{
    "version": 1.0,
    "auths": {
        "cloud.openshift.com": {
            "auth": "XXX",
            "email": "johndoe@example.com"
        },
        "quay.io": {
            "auth": "XXX",
            "email": "johndoe@example.com"
        },
        "registry.connect.redhat.com": {
            "auth": "XXX",
            "email": "johndoe@example.com"
        },
        "registry.redhat.io": {
            "auth": "XXX",
            "email": "johndoe@example.com"
        }
    }
}

[wking]

Due #1320, i discovered that the schema for the pull-secret has changed to include more authentication credentials.

That's a data change, not a schema change. Validating the data as sufficient is hard, because it depends on what you end up installing (more in #901). #1286 will give us some installer-side validation, but it would not have prevented #1320.

On the schema side, I'm fine without a version, since the format has been backwards compatible for years. But I'm not strongly against explicit versioning either. It's probably better to have that discussion upstream in containers/image though.

[abhinavdahiya]

This is not somethings installer can fix.

/close

[openshift-ci-robot]

@abhinavdahiya: Closing this issue.

In response to this:

This is not somethings installer can fix.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.