Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples directory still used though it's removed from the repo #368

Closed
ashcrow opened this issue Sep 28, 2018 · 4 comments
Closed

examples directory still used though it's removed from the repo #368

ashcrow opened this issue Sep 28, 2018 · 4 comments
Assignees

Comments

@ashcrow
Copy link
Member

ashcrow commented Sep 28, 2018

Versions

06a4afb

What happened?

The following still reference examples/ which is no longer available:

What you expected to happen?

If examples/ is needed it should be in the repo (or a reference on how to get it should be available). Otherwise, the references to examples/ should be removed.

How to reproduce it (as minimally and precisely as possible)?

Look at the files :-D

@wking
Copy link
Member

wking commented Sep 28, 2018

/assign

@wking
Copy link
Member

wking commented Sep 28, 2018

I've updated the docs in #369.

Updating tests/ will be more difficult, because the smoke tests currently assume Bazel, and we dropped our remaining Bazel bits last night in #342. It would be nice to drop our tests/smoke completely, and possibly just update tests/run.sh to use the end-to-end suite we currently use in CI.

@crawford
Copy link
Contributor

crawford commented Jan 4, 2019

This has since been fixed.

/close

@openshift-ci-robot
Copy link
Contributor

@crawford: Closing this issue.

In response to this:

This has since been fixed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants