OCPBUGS-6663: Check platform baremetal settings against default values #6809

bfournie · 2023-01-26T20:24:10Z

Spurious warning are being generated for platform baremetal values. Compare the values to default in order to detect the values were set in install-config.

Since the default values for MAC addresses are generated a valid comparison can't be done, so these checks have been removed.

openshift-ci-robot · 2023-01-26T20:24:17Z

@bfournie: This pull request references Jira Issue OCPBUGS-6663, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zniu1011

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Spurious warning are being generated for platform baremetal values. Compare the values to default in order to detect the values were set in install-config.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bfournie · 2023-01-26T20:24:41Z

/cc @zaneb @rwsu @andfasano

openshift-ci-robot · 2023-01-26T20:26:02Z

@bfournie: This pull request references Jira Issue OCPBUGS-6663, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zniu1011

In response to this:

Spurious warning are being generated for platform baremetal values. Compare the values to default in order to detect the values were set in install-config.

Since the default values for MAC addresses are generated a valid comparison can't be done, so these checks have been removed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rwsu

/lgtm

rwsu · 2023-01-30T12:11:20Z

pkg/asset/agent/installconfig.go

 			fieldPath := field.NewPath("Platform", "Baremetal", "ExternalBridge")
 			logrus.Warnf(fmt.Sprintf("%s: %s is ignored", fieldPath, baremetal.ExternalBridge))
 		}
-		if baremetal.ExternalMACAddress != "" {


Good catch. I would have assumed the MAC address would have been blank instead of randomized.

rwsu · 2023-01-30T12:12:41Z

/retest-required

Spurious warning are being generated for platform baremetal values. Compare the values to default in order to detect the values were set in install-config.

bfournie · 2023-01-30T13:59:37Z

Fixed lint issue

andfasano · 2023-01-30T17:57:17Z

/lgtm

bfournie · 2023-01-30T18:10:44Z

/cherry-pick release-4.12

openshift-cherrypick-robot · 2023-01-30T18:10:46Z

@bfournie: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rwsu · 2023-01-31T03:45:23Z

/retest-required

openshift-ci · 2023-01-31T03:45:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/asset/agent/OWNERS~~ [rwsu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-01-31T06:50:27Z

@bfournie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-upi-zones	`ce99013`	link	false	`/test e2e-vsphere-upi-zones`
ci/prow/e2e-agent-sno-ipv6	`ce99013`	link	false	`/test e2e-agent-sno-ipv6`
ci/prow/e2e-aws-ovn-workers-rhel8	`ce99013`	link	false	`/test e2e-aws-ovn-workers-rhel8`
ci/prow/e2e-gcp-secureboot	`ce99013`	link	false	`/test e2e-gcp-secureboot`
ci/prow/e2e-aws-ovn-disruptive	`ce99013`	link	false	`/test e2e-aws-ovn-disruptive`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-01-31T06:55:20Z

@bfournie: All pull requests linked via external trackers have merged:

openshift/installer#6809

Jira Issue OCPBUGS-6663 has been moved to the MODIFIED state.

In response to this:

Spurious warning are being generated for platform baremetal values. Compare the values to default in order to detect the values were set in install-config.

Since the default values for MAC addresses are generated a valid comparison can't be done, so these checks have been removed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2023-01-31T06:56:59Z

@bfournie: new pull request created: #6815

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zaneb · 2023-01-31T23:52:59Z

pkg/asset/agent/installconfig.go

@@ -187,58 +188,53 @@ func warnUnusedConfig(installConfig *types.InstallConfig) {
 	switch installConfig.Platform.Name() {

 	case baremetal.Name:
+		defaultIc := &types.InstallConfig{Platform: types.Platform{BareMetal: &baremetal.Platform{}}}


In the case where the provisioning network is disabled and the ProvisioningIP is set, the default ProvisioningNetworkCIDR is derived from network CIDRs in the install-config. We could avoid a warning in that case by starting with a copy of the InstallConfig, instead of a blank one. (However, there will already be warnings about ProvisioningNetwork=disabled and ProvisioningIP in that case, so this is not a big deal.)

openshift-ci bot requested a review from zniu1011 January 26, 2023 20:24

openshift-ci bot requested review from andfasano, rwsu and zaneb January 26, 2023 20:24

openshift-ci bot requested a review from pawanpinjarkar January 26, 2023 20:27

rwsu reviewed Jan 30, 2023

View reviewed changes

openshift-ci bot assigned rwsu Jan 30, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023

OCPBUGS-6663: Check platform baremetal settings against default values

ce99013

Spurious warning are being generated for platform baremetal values. Compare the values to default in order to detect the values were set in install-config.

bfournie force-pushed the agent-platform-defaults branch from 8023836 to ce99013 Compare January 30, 2023 13:58

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023

openshift-ci bot assigned andfasano Jan 30, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023

rwsu approved these changes Jan 31, 2023

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023

openshift-merge-robot merged commit 58e4ed8 into openshift:master Jan 31, 2023

openshift-cherrypick-robot mentioned this pull request Jan 31, 2023

[release-4.12] OCPBUGS-6807: Check platform baremetal settings against default values #6815

Merged

bfournie deleted the agent-platform-defaults branch January 31, 2023 12:18

zaneb reviewed Jan 31, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-6663: Check platform baremetal settings against default values #6809

OCPBUGS-6663: Check platform baremetal settings against default values #6809

bfournie commented Jan 26, 2023 •

edited

Loading

openshift-ci-robot commented Jan 26, 2023

bfournie commented Jan 26, 2023

openshift-ci-robot commented Jan 26, 2023

rwsu left a comment

rwsu Jan 30, 2023

rwsu commented Jan 30, 2023

bfournie commented Jan 30, 2023

andfasano commented Jan 30, 2023

bfournie commented Jan 30, 2023

openshift-cherrypick-robot commented Jan 30, 2023

rwsu commented Jan 31, 2023

openshift-ci bot commented Jan 31, 2023

openshift-ci bot commented Jan 31, 2023

openshift-ci-robot commented Jan 31, 2023

openshift-cherrypick-robot commented Jan 31, 2023

zaneb Jan 31, 2023

OCPBUGS-6663: Check platform baremetal settings against default values #6809

OCPBUGS-6663: Check platform baremetal settings against default values #6809

Conversation

bfournie commented Jan 26, 2023 • edited Loading

openshift-ci-robot commented Jan 26, 2023

bfournie commented Jan 26, 2023

openshift-ci-robot commented Jan 26, 2023

rwsu left a comment

Choose a reason for hiding this comment

rwsu Jan 30, 2023

Choose a reason for hiding this comment

rwsu commented Jan 30, 2023

bfournie commented Jan 30, 2023

andfasano commented Jan 30, 2023

bfournie commented Jan 30, 2023

openshift-cherrypick-robot commented Jan 30, 2023

rwsu commented Jan 31, 2023

openshift-ci bot commented Jan 31, 2023

openshift-ci bot commented Jan 31, 2023

openshift-ci-robot commented Jan 31, 2023

openshift-cherrypick-robot commented Jan 31, 2023

zaneb Jan 31, 2023

Choose a reason for hiding this comment

bfournie commented Jan 26, 2023 •

edited

Loading