Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is v0.7 installer pinned to specific openshift release ? #930

Closed
DanyC97 opened this issue Dec 17, 2018 · 7 comments
Closed

is v0.7 installer pinned to specific openshift release ? #930

DanyC97 opened this issue Dec 17, 2018 · 7 comments

Comments

@DanyC97
Copy link
Contributor

DanyC97 commented Dec 17, 2018

Version

 # ./openshift-install-linux-amd64 version
./openshift-install-linux-amd64 v0.7.0
# sha256sum openshift-install-linux-amd64 
879d1966b229a4723520b0522e9bd79308071c8cfae2b13e14800948c45ea73f  openshift-install-linux-amd64

Platform (aws|libvirt|openstack):

aws

What happened?

Trying to deploy a cluster and while scanning the logs i've noticed the below in the boostrap's journalctl output

1-129 bootkube.sh[4434]: Trying to pull quay.io/openshift-release-dev/ocp-release:4.0.0-6...Getting image source signatures
Dec 17 18:15:58 ip-10-0-1-129 bootkube.sh[4434]: Copying blob sha256:a02a4930cb5d36f3290eb84f4bfa30668ef2e9fe3a1fb73ec015fc58b9958b17
Dec 17 18:16:03 ip-10-0-1-129 bootkube.sh[4434]: [503B blob data]
Dec 17 18:16:03 ip-10-0-1-129 bootkube.sh[4434]: Copying blob sha256:9afeca73426ec14b331e7968e69e8514225c232ecf782a31c08935c6eebd063c
Dec 17 18:16:05 ip-10-0-1-129 bootkube.sh[4434]: [119B blob data]
Dec 17 18:16:05 ip-10-0-1-129 bootkube.sh[4434]: Copying blob sha256:8c631e03cd56d716a5966b766ff589b7702b7b643cc41a841f4c84f58fa0c4f6
Dec 17 18:16:08 ip-10-0-1-129 bootkube.sh[4434]: [301B blob data]
Dec 17 18:16:08 ip-10-0-1-129 bootkube.sh[4434]: Copying blob sha256:21dcbb91f69fca7abce98841c6e654cf9c74ce12b17f8f8441d1b1b97ed4a2c3
Dec 17 18:16:09 ip-10-0-1-129 bootkube.sh[4434]: [67B blob data]
Dec 17 18:16:09 ip-10-0-1-129 bootkube.sh[4434]: Writing manifest to image destination
Dec 17 18:16:09 ip-10-0-1-129 bootkube.sh[4434]: Storing signatures
Dec 17 18:16:16 ip-10-0-1-129 bootkube.sh[4434]: 5d537bf661a70aba1fb621e759c56eecca06b26de32698f9ef5fa09c2ba8b274
Dec 17 18:16:27 ip-10-0-1-129 bootkube.sh[4434]: Rendering Cluster Version Operator Manifests...
Dec 17 18:16:28 ip-10-0-1-129 bootkube.sh[4434]: Rendering Kubernetes API server core manifests...
Dec 17 18:16:29 ip-10-0-1-129 bootkube.sh[4434]: Trying to pull quay.io/openshift-release-dev/ocp-v4.0@sha256:5e1f172040c411d4768bf419372c847fd10a2456ce612957cb2acac18c425e28...Getting image source signatures


What you expected to happen?

Expecting to see 4.0.0-7 and the layers below

skopeo inspect docker://quay.io/openshift-release-dev/ocp-release:4.0.0-7
{
    "Name": "quay.io/openshift-release-dev/ocp-release",
    "Tag": "4.0.0-7",
    "Digest": "sha256:3e70b2d2004c9335dabc24d6259c5b03739fd86eae435c191ee2b8592e86efec",
    "RepoTags": [
        "4.0.0-0",
        "4.0.0-1",
        "4.0.0-2",
        "4.0.0-3",
        "4.0.0-5",
        "4.0.0-4",
        "4.0.0-6",
        "4.0.0-7"
    ],
    "Created": "2018-12-15T06:41:33.392131088Z",
    "DockerVersion": "1.13.1",
    "Labels": {
        "io.openshift.release": "4.0.0-7",
        "io.openshift.release.base-image-digest": "sha256:f9585cce1889d934b6f9c8361bb1fcc532235ddc4b88ab8614be40545e6bf5d8"
    },
    "Architecture": "amd64",
    "Os": "linux",
    "Layers": [
        "sha256:a02a4930cb5d36f3290eb84f4bfa30668ef2e9fe3a1fb73ec015fc58b9958b17",
        "sha256:9afeca73426ec14b331e7968e69e8514225c232ecf782a31c08935c6eebd063c",
        "sha256:8c631e03cd56d716a5966b766ff589b7702b7b643cc41a841f4c84f58fa0c4f6",
        "sha256:0960e51c3ab7e61ef6b9632eeb4e9a01038709c8dc23034b0a015b1e3bc55fe4"
    ]
}

How to reproduce it (as minimally and precisely as possible)?

$ your-commands-here

Anything else we need to know?

I've also tried to override the image but that didn't make any difference, am i doing something wrong with this variable ?

export OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE="registry.svc.ci.openshift.org/openshift/origin-release:4.0.0-7"

References

  • enter text here.
@DanyC97 DanyC97 changed the title is v0.7 installer pin to specific specific release ? is v0.7 installer pinned to specific specific release ? Dec 17, 2018
@DanyC97 DanyC97 changed the title is v0.7 installer pinned to specific specific release ? is v0.7 installer pinned to specific openshift release ? Dec 17, 2018
@abhinavdahiya
Copy link
Contributor

Yes, installer releases pin the RHCOS version and release image version.

@abhinavdahiya
Copy link
Contributor

export OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE="registry.svc.ci.openshift.org/openshift/origin-release:4.0.0-7"

the released installer currently does not support override the release image with OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE.

@DanyC97
Copy link
Contributor Author

DanyC97 commented Dec 17, 2018

Yes, installer releases pin the RHCOS version and release image version.

you mind showing/ pointing me at the code where it does that ?

he released installer currently does not support override the release image with OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE

is any other release which does ? cause if not then i'm surprised to hear since your CI does use it or one of your operator

@abhinavdahiya
Copy link
Contributor

here's an example #918

@DanyC97
Copy link
Contributor Author

DanyC97 commented Dec 17, 2018

right and i've seen that before but is not in master, the PR was closed w/o getting merged and so i expect to have no pin release image

@abhinavdahiya
Copy link
Contributor

right and i've seen that before but is not in master, the PR was closed w/o getting merged and so i expect to have no pin release image

we use that PR to test our pinned assets and push a tag to the repo from that commit.

$ git log v0.7.0 --pretty=oneline --graph
* 17ffd16d917ddbb7d1f0eeff9833289bff560437 (tag: v0.7.0) hack/build: Pin to RHCOS 47.212 and quay.io/openshift-release-dev/ocp-release:4.0.0-6
* 04dda380bee6f52b40046905c054eb10cc7d9489 CHANGELOG: Document changes since 5813f611
*   874876e40a758aa08f5cbcafb42c78ecf2e3c97c Merge pull request #711 from staebler/improve_input_validation
|\
| * 355cad88114cdc12457b2a3f883812b3bdc5cd4b .: describe how to run unit tests in CONTRIBUTING.md
| * 0ce4e263ab4e81fbf86a72d1b84d01bc9e071fa6 asset/installconfig: validate openstack platform values in install-config.yml
| * e5bb73ecb4bb4916157189f38b8e2662811c3c18 vendor: add github.com/golang/mock/gomock
| * cfc5eacfb1ce5cb129723513003c7e4e1c74a0c5 asset/installconfig: unit tests for InstallConfig.Load
| * da09a306aee161f2c2ffb6574dbeca2bdeba93f1 types: unit tests for InstallConfig validation
| * c793af102e95a897b5914fc3622d89f8f9c5806f validate: remove unused functions
| * 4ccebbf7e8a33845d00f567e25d0e5def2819ebf asset/installconfig: remove emailaddress asset
| * e2d281ae85f2021b460e68127944ce1563190ff8 asset/installconfig: validate InstallConfig loaded from file
| * b2d6fa405b3ed9c669f6d0a3c61d2d600cb50cf0 validate: simplify CIDR validation
| * d813360470016e97f28f23d7de331ec67f35e642 asset/installconfig: move uri validation to validation package
| * ef9282d50ef6f0086894e86e0b8aa099906148ce vendor: golang.org/x/crypto ssh sub-package
| * d2c528f7adb698b9d1569efa0514e53a7f71165c validate: improve ssh public key validation
| * 1df7704a520e5252e7b9f8654c9bb936a0bd417f validate: improve image pull secret validation
| * c001cbd5c8d219a44a3e333ce9ca17e9e5f02a5e validate: improve cluster name validation
| * 3badd35adcc941cd3d6cc314530b029b582f5717 validate: improve base domain validation
* |   4d230b6d047509a57ab8095ed801a047b203c0e3 Merge pull request #757 from rajatchopra/pin_os
|\ \
| |/
|/|
| * 07f17f4163693a926487e4e46f46b1b9c0d0d9ff hack: pin the os release build name
| * 3ef7dbfdbb4a938774f889d3e1069ef47944082a hack: pin the release image in build flags
* |   14505f396dd4d01014c86c08703c960a0f6e1819 Merge pull request #911 from hardys/issues/891
|\ \
| * | fb73b45ca90d9ffe5d2428841444580a039c2614 OpenStack Destroy, tolerate temporary router delete failure
| |/
* |   3b9d99be000ff61abd4ea7e81952f72d4c5f0388 Merge pull request #654 from staebler/no_shared_aws_vpc
|\ \
| * | 04719388d42867895bf8bc543b5ba7c603a27adb terraform: remove some more unused aws variables
| * | 58a84e97ce45d3761e0c37f93ddff193cf4562d1 terraform/aws: remove unused options around using external VPC
| * | 6f55e6738913349077ad29b67b3d4139b8b62905 terraform/aws: remove option to use an existing vpc in aws
* | |   e86e78b855e8c7b244b5a1082fcff8e981e11501 Merge pull request #913 from ivuk/fix-typo
|\ \ \
| * | | d9c7560b24c52481d439aa6e300c7017a2f0c885 Fix a typo in libvirt-howto.md
| | |/
| |/|
* | |   17c7e3ffb5ad2c26f265293d9ff0095ad1b0bd6f Merge pull request #906 from wking/version-0.7.0
|\ \ \
| * | | 743a196df8892c04d0bf15957262170e85161668 CHANGELOG: Document changes since 2018-12-07
| | |/
| |/|
* | |   269cfd1ea8ee71b02e3af463f12c904891af7bd7 Merge pull request #903 from abhinavdahiya/dockerfile
|\ \ \
| * | | 97482d5c8e03874dda28a4273596bc7bfd7a2c45 (origin/dockerfile, dockerfile) image: Add a RHEL7 dockerfile and standarize format
* | | |   4c2005c96178403442c8922ee27fd183df6b25ad Merge pull request #914 from abhinavdahiya/docs
|\ \ \ \
| * | | | a93818e9a9bf9487e556c3c140c582cb55a80761 (origin/docs, docs) docs: include `dep version` command in Go section
* | | | |   e3222c99bb00bc7a7d162632ec2e79d4cfd3e052 Merge pull request #907 from wking/suggest-attaching-logs
|\ \ \ \ \
| * | | | | 66648661eb5183f4a8cc40701ae399b67b1804a9 .github/ISSUE_TEMPLATE: Explicitly mention .openshift_install.log
| * | | | | 96cc01057c492f4fae4d7034c9f2a7ef70c02319 *: Fix ".openshift-install.log" -> ".openshift_install.log"
| | |_|/ /
| |/| | |
* | | | |   0ac5f34ad9c80fb8ce61680c2b1e2f6e9d1d7a56 Merge pull request #905 from wking/drop-dead-code-no-routes-error
|\ \ \ \ \
| |_|/ / /
|/| | | |
| * | | | cc71276000c7a673d757d316fcb2aea1a00531cc cmd/openshift-install/create: Drop dead-code "no routes found" error
| |/ / /
* | | |   d282893cb788523c959b50685c72456837ea1652 Merge pull request #912 from hardys/swift_destroy_failure
|\ \ \ \
| |_|_|/
|/| | |
| * | | 3501ce9898e473b5a7b551371c13302a136f8ea1 OpenStack Destroy, break after matching swift container metadata
|/ / /
* | |   2897ed7184af18d563f11764b89517d3c2f44a9b Merge pull request #904 from russellb/openstack-hacks
|\ \ \
| |/ /
|/| |
| * | 8f282a4a441586d339bbf88668eceb6f8ffb3335 openstack: Add OpenStack docs.
| * | 8958e2e08381bd08d3009191040dc5e27ad74a44 openstack: Add a temporary service VM.

@DanyC97
Copy link
Contributor Author

DanyC97 commented Dec 17, 2018

oh, very interesting ... thank you for letting me know about this process @abhinavdahiya

@DanyC97 DanyC97 closed this as completed Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants