Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: increase validity of client cert used for boostrapping masters to 1 day #1044

Merged
merged 1 commit into from
Jan 12, 2019
Merged

tls: increase validity of client cert used for boostrapping masters to 1 day #1044

merged 1 commit into from
Jan 12, 2019

Conversation

abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Jan 10, 2019 •
edited by wking
Loading

The 30 minutes validity was necessary as before #879 the client certificate provided
cluster admin rights. But after #879 the client certificate only has access to CSR endpoint.

Therefore, we can safely increase the validity to something longer.

/cc @crawford

Fixes #650.

@abhinavdahiya
tls: increase validity of client cert used for boostrapping masters t…
d6b850c 
…o 1 day

The 30 minutes validity was necessary as before openshift#879 the client certificate provided
cluster admin rights. But after openshift#879 the client certificate only has access to CSR endpoint.

Therefore, we can safely increase the validity to something longer.
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2019
@wking
Copy link
Member

wking commented Jan 10, 2019

/approve

@abhinavdahiya abhinavdahiya added this to the Freeze milestone Jan 10, 2019
@wking
Copy link
Member

wking commented Jan 10, 2019

Reasonable feedback window has passed ;).

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2019
@crawford
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,crawford,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@abhinavdahiya
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 761e172 into openshift:master Jan 12, 2019
@wking wking mentioned this pull request Jan 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford Awaiting requested review from crawford

Assignees

@wking wking

@crawford crawford

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Freeze
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@abhinavdahiya @wking @crawford @openshift-ci-robot @openshift-bot @openshift-merge-robot