openstack: Always set opts.Cloud #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If OS_CLOUD is not set in the environment, this part of the code will fail with a NPE because neither OS_CLOUD nor opts.Cloud are set. Set opts.Cloud to the value in Platform.
|
/hold |
openshift-ci-robot
added
do-not-merge/hold
wking
changed the title
|
/assign @tomassedovic |
|
LGTM after the merge freeze is over. Thanks! |
|
It's fine to merge bugfixes /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm This is a bug fix for a rather confusing error. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flaper87, tomassedovic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If OS_CLOUD is not set in the environment, this part of the code will
fail with a NPE because neither OS_CLOUD nor opts.Cloud are set. Set
opts.Cloud to the value in Platform.