Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overview: warn about install-config.yaml deletion #1122

Merged
merged 1 commit into from
Jan 25, 2019
Merged

overview: warn about install-config.yaml deletion #1122

merged 1 commit into from
Jan 25, 2019

Conversation

dankenigsberg
Copy link
Contributor

I don't understand why it makes sense and find it surprising. Let's warn other readers.

@crawford can you confirm that this is the intended behavior, and maybe explain the logic behind it?

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2019
@dankenigsberg dankenigsberg mentioned this pull request Jan 23, 2019
Closed
wking
wking reviewed Jan 23, 2019
View reviewed changes
docs/user/overview.md Outdated Show resolved Hide resolved
wking
wking reviewed Jan 23, 2019
View reviewed changes
docs/user/overview.md Outdated Show resolved Hide resolved
@wking
Copy link
Member

wking commented Jan 23, 2019

Motivation for the removal and further discussion in #898.

dankenigsberg
dankenigsberg commented Jan 24, 2019
View reviewed changes
docs/user/overview.md
@@ -60,7 +60,7 @@ mv initial/install-config.yaml .
rm -rf initial
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crawford @wking what is the name of the "hidden file" mentioned above? It is quite mysterious to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.openshift_install_state.json

wking
wking reviewed Jan 25, 2019
View reviewed changes
docs/user/overview.md Outdated Show resolved Hide resolved
@wking
Copy link
Member

wking commented Jan 25, 2019

Can you also squash down to one commit?

@dankenigsberg
Copy link
Contributor Author

Can you also squash down to one commit?

Does GitHub GUI allow this basic functionality? I'll use the command line if not.

@wking
Copy link
Member

wking commented Jan 25, 2019

Can you also squash down to one commit?

Does GitHub GUI allow this basic functionality?

Not to my knowledge.

@wking wking added this to the 0.11.0 milestone Jan 25, 2019
@wking wking mentioned this pull request Jan 25, 2019
Merged
@wking
Copy link
Member

wking commented Jan 25, 2019

Aha, looks like you've allowed maintainer edits, because GitHub let me force-push a squash to your branch with 2b2a6a0 -> 4c6fca4. Does 4c6fca4 look good to you, @dankenigsberg ?

@dankenigsberg
Copy link
Contributor Author

lvgtm.

@wking
Copy link
Member

wking commented Jan 25, 2019

/lgtm

Thanks :)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dankenigsberg, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2019
@openshift-merge-robot openshift-merge-robot merged commit 20dc5c3 into openshift:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking left review comments

@crawford crawford Awaiting requested review from crawford

@flaper87 flaper87 Awaiting requested review from flaper87

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dankenigsberg @wking @openshift-ci-robot @crawford @openshift-merge-robot