-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase timeout for console route #1143
Increase timeout for console route #1143
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sallyom If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@abhinavdahiya ok sounds good, I'll leave this open for now while we see if that change resolves the timeout failures. thanks |
Is there any reason not to merge this now while #1132 is in progress? We're still losing time to this. |
Will increasing the timeout actually improve our failure rate or will it just take longer to fail? I'm fine with this change if it will help with CI, but of the failures I've personally seen, none of them would be helped by this PR. |
You might be right. Looking back over prior discussion it's not clear to me whether the failure mode is an intermittent delayed creation or a total lack of creation. If the latter, this PR wouldn't help. |
On the other hand, when's the last time you saw a PR pass tests so easily? :) |
#1132 should have addressed this, so... /close But please comment if you still see timeouts :). |
@wking: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm seeing this issue when installing with AWS locally, and it's also been causing CI failures.