-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim down the worker iam role #1200
Conversation
The kubelet was suspected to use attach/detach volume and load balancer apis, but apparently not. We can trim the privileges down to minimum now. The last big one remaining is DescribeInstances that is stuck because of instance 'tags'.
This looks fine to me (and I expect e2e to pass, but am happy it's there just in case ;). Should I |
@rajatchopra: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Lets get this through. I will check with S3 permissions and put another PR about it - don't want to pile it on without basic evidence for it. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rajatchopra, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The kubelet was suspected to use attach/detach volume and load balancer apis, but
apparently not. We can trim the privileges down to minimum now.
The last big one remaining is DescribeInstances that is stuck because of instance 'tags'.
The cluster comes up just fine, now hoping I didn't miscalculate on actual workloads.. time for the virtuous e2e to shine.
Part 2: Try removing s3 access also and see what gives.