Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim down the worker iam role #1200

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

rajatchopra
Copy link
Contributor

The kubelet was suspected to use attach/detach volume and load balancer apis, but
apparently not. We can trim the privileges down to minimum now.
The last big one remaining is DescribeInstances that is stuck because of instance 'tags'.

The cluster comes up just fine, now hoping I didn't miscalculate on actual workloads.. time for the virtuous e2e to shine.

Part 2: Try removing s3 access also and see what gives.

The kubelet was suspected to use attach/detach volume and load balancer apis, but
apparently not. We can trim the privileges down to minimum now.
The last big one remaining is DescribeInstances that is stuck because of instance 'tags'.
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 6, 2019
@wking
Copy link
Member

wking commented Feb 6, 2019

This looks fine to me (and I expect e2e to pass, but am happy it's there just in case ;). Should I /lgtm now, or do you plan on iterating here until you have the worker all tightened up? What about the master and bootstrap configs (bootstrap may need to retain more than masters, at least S3 get for the bootstrap Ignition config).

@openshift-ci-robot
Copy link
Contributor

@rajatchopra: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 4dfd6f7 link /test e2e-openstack
ci/prow/e2e-libvirt 4dfd6f7 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rajatchopra
Copy link
Contributor Author

This looks fine to me (and I expect e2e to pass, but am happy it's there just in case ;). Should I /lgtm now, or do you plan on iterating here until you have the worker all tightened up? What about the master and bootstrap configs (bootstrap may need to retain more than masters, at least S3 get for the bootstrap Ignition config).

Lets get this through. I will check with S3 permissions and put another PR about it - don't want to pile it on without basic evidence for it.
We plan to keep Masters and Bootstrap as it is for now - bootstrap is shortlived, and cleaning up master is a longer task. At least with this we have reduced the attack surface.

@wking
Copy link
Member

wking commented Feb 6, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rajatchopra, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants