-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openstack: Use a service subnet for service-vm #1224
openstack: Use a service subnet for service-vm #1224
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flaper87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Move the service VM under its own subnet. This helps creating deployment-only resources that can be easily cleaned after the fact. For example, we can set the nodes' subnet dns nameservers to point to the service-vm and then set it to something else after the deployment succeeds in scenarios where users bring their own DNS.
9918700
to
3d825dd
Compare
Thanks! This looks great & we want it. But I've noticed that the workers come up in the It's not introducing any regressions, so we can do that in a follow-up patch. Let me know what you think. |
@tomassedovic probably better in a follow-up patch because I'm afraid that may not be related to this PR. :/ |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
Move the service VM under its own subnet. This helps creating deployment-only resources that can be easily cleaned after the fact.
For example, we can set the nodes' subnet dns nameservers to point to the service-vm and then set it to something else after the deployment succeeds in scenarios where users bring their own DNS.
/cc @tomassedovic