Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG: Document changes since v0.12.0 #1270

Merged
merged 1 commit into from
Feb 24, 2019
Merged

CHANGELOG: Document changes since v0.12.0 #1270

merged 1 commit into from
Feb 24, 2019

Conversation

wking
Copy link
Member

@wking wking commented Feb 19, 2019

Through 820ff4c (#1179).

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 19, 2019
@wking
Copy link
Member Author

wking commented Feb 19, 2019

images:

2019/02/19 09:22:03 Container release in pod release-latest completed successfully
2019/02/19 09:22:03 Pod release-latest succeeded after 1m49s
2019/02/19 09:22:03 Copying artifacts from release-latest into /logs/artifacts/release-latest
2019/02/19 09:22:03 Copied 0.27Mi of artifacts from release-latest to /logs/artifacts/release-latest
2019/02/19 09:22:09 Ran for 12m10s
error: could not run steps: test "release-latest" failed: pod release-latest was already deleted

/retest

@crawford
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

abhinavdahiya
abhinavdahiya reviewed Feb 19, 2019
View reviewed changes
CHANGELOG.md Outdated
- `metadata.json` is generated before the Terraform invocation, fixing
a bug introduced in 0.12.0 which made it hard to clean up after
failed Terraform creation.
- The machine-configuration server has moved its Ignition-config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

machine-config-server

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignition config

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

machine-config-server

machine-config(uration) is an adjective describing the type of server, so I've left of the hyphen but abbreviated "configuration" with b6882f2 -> 8f08508.

Ignition config

Ignition-config is an adjective describing the type of service, so I've left it hyphenated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignition-config is an adjective describing the type of service

Ignition-config is a service? Not sure what you are trying to imply?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignition-config is a service? Not sure what you are trying to imply?

The machine-config server serves Ignition-configuration content, right?

abhinavdahiya
abhinavdahiya reviewed Feb 19, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
abhinavdahiya
abhinavdahiya reviewed Feb 19, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
abhinavdahiya
abhinavdahiya reviewed Feb 19, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
abhinavdahiya
abhinavdahiya reviewed Feb 19, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
abhinavdahiya
abhinavdahiya reviewed Feb 19, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@wking
CHANGELOG: Document changes since v0.12.0
8f08508 
Through 820ff4c (Merge pull request openshift#1179 from mrogers950/ca_roots,
2019-02-19).
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2019
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,crawford,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

DanyC97
DanyC97 reviewed Feb 20, 2019
View reviewed changes
CHANGELOG.md

- On AWS, control-plane nodes have been moved to private subnets and
no longer have public IPs. Use a VPN or bastion host if you need
SSH access to them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wking maybe you would consider to add the ssh pod solution which was mentioned in the PR? Otherwise people will come back (natural i'd say) saying: isn't installer's scope to give me a bastion too and not many will lookup up the conversation where it was mentioned the decision to not provide one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you would consider to add the ssh pod solution...

You don't think they'd see the docs?

Copy link
Contributor

@DanyC97 DanyC97 Feb 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully. I guess is per individual in terms of the flow:

a) for each release they are looking at the changelog and scan the docs from A to Z to figure out if anything new was added/ removed OR
b) for each release they are looking only at the changelog and doesn't review the docs (assuming that nothing has changed).

is arguable imo but up to you

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6b6b55b into openshift:master Feb 24, 2019
@DanyC97 DanyC97 mentioned this pull request Feb 25, 2019
Closed
wking added a commit to wking/openshift-installer that referenced this pull request Feb 26, 2019
@wking
CHANGELOG: Document changes since 8f08508
fdcac06 
Through 6b6b55b (Merge pull request openshift#1270 from wking/version-0.13.0,
2019-02-24).
@wking wking mentioned this pull request Feb 26, 2019
Merged
wking added a commit to wking/openshift-installer that referenced this pull request Feb 27, 2019
@wking
CHANGELOG: Document changes since 8f08508
e77eba4 
Through 6b6b55b (Merge pull request openshift#1270 from wking/version-0.13.0,
2019-02-24).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@DanyC97 DanyC97 DanyC97 left review comments

@flaper87 flaper87 Awaiting requested review from flaper87

@tomassedovic tomassedovic Awaiting requested review from tomassedovic

Assignees

@crawford crawford

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wking @crawford @openshift-bot @abhinavdahiya @openshift-ci-robot @DanyC97 @openshift-merge-robot