tls: switch to self-signed admin.kubeconfig #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
The KAS now trusts the admin.kubeconfig client cert. We can remove the old kube-ca signed admin.kubeconfig to more appropriately scope trust.
deads2k
force-pushed
the
admin-kubeconfig-2
branch
from
b3c2910
to
ab86bba
Compare
|
/test e2e-aws |
it was green from a run two hours ago. Why the kick? |
deads2k
added
approved
|
per slack, this was just waiting for another green e2e run. Looks good. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Feb 27, 2019
Through 0208204 (Merge pull request openshift#1305 from deads2k/admin-kubeconfig-2, 2019-02-25).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that openshift/cluster-kube-apiserver-operator#297 merged, we can remove the deprecated admin.kubeconfig that used to be in that shared chain.
The kubelet.kubeconfig will take more thought/work because it needs a distinct, long lived signer that can be maintained by something managing the machine configuration for rotation.