tls: create a client-ca bundle for the bootstrap KAS to use #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
The bootstrap KAS points to files loaded on disk. This means we need to build a CA bundle that can be referenced directly.
deads2k
force-pushed
the
cert-clients
branch
from
1a70b1a
to
39a1a57
Compare
|
this in keeping with the rest of the CA bundles and necessary for the separated chains of trust. I'm tagging it, but will take post-merge comments on Monday if they come up. |
deads2k
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bootstrap KAS points to files loaded on disk. This means we need to build
a CA bundle that can be referenced directly.
If this passes, I'd like to merge it to try to move forward with the correct CSR bundle for kubelets.