Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/openshift-install/waitfor: Rename from user-provided-infrastructure #1552

Merged
merged 1 commit into from
Apr 8, 2019

Commits on Apr 8, 2019

  1. cmd/openshift-install/waitfor: Rename from user-provided-infrastructure

    There is no hard line between installer- and user-provided
    infrastructure.  Rename these commands to focus on what they'll do
    instead of the work-flow into which we expect them to fit.
    
    We're still working out how we can drop the router-CA injection to
    avoid 'wait-for cluster-ready' surprising users my editing their
    on-disk kubeconfig [1].  But that's mitigated somewhat by the fact
    that addRouterCAToClusterCA is idempotent, because AppendCertsFromPEM
    wraps AddCert [2] and AddCert checks to avoid duplicate certificates
    [3].
    
    [1]: openshift#1541
    [2]: https://github.com/golang/go/blob/go1.12/src/crypto/x509/cert_pool.go#L144
    [3]: https://github.com/golang/go/blob/go1.12/src/crypto/x509/cert_pool.go#L106-L109
    wking committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    8cd13c0 View commit details
    Browse the repository at this point in the history