Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating architecture diagram based on Dia #1647

Merged
merged 1 commit into from Apr 23, 2019
Merged

Updating architecture diagram based on Dia #1647

merged 1 commit into from Apr 23, 2019

Conversation

cuppett
Copy link
Member

@cuppett cuppett commented Apr 17, 2019

Still waiting on #1525 to land. In the meantime, updating the picture in the IPI docs to reflect the private masters and be consistent with the diagram in the UPI docs.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2019
@cuppett
Copy link
Member Author

cuppett commented Apr 17, 2019

/assign @wking

@abhinavdahiya
Copy link
Contributor

#1525 is LGTMed and in merge queue

@cuppett
Copy link
Member Author

cuppett commented Apr 18, 2019

/hold

Will add a chaser commit to rebase on #1525 and adopt the SVG output from that.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2019
@cuppett
Copy link
Member Author

cuppett commented Apr 22, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2019
@wking
Copy link
Member

wking commented Apr 23, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cuppett, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2019
@openshift-merge-robot openshift-merge-robot merged commit b440a7f into openshift:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants