Setup ownership of libvirt code #1662
Conversation
openshift-ci-robot
added
the
size/M
zeenix
force-pushed
the
libvirt-ownership
branch
from
94de560
to
132ed2a
Compare
|
@zeenix Thanks for helping maintain the libvirt platform.
|
OK. I'll remove approvers from that one. |
zeenix
force-pushed
the
libvirt-ownership
branch
from
132ed2a
to
fb590f5
Compare
Can you write this up in your commit message? Currently I could see some future dev looking at the commit and thinking the |
|
/test e2e-metal |
|
/test e2e-metal |
This is to give ownership of libvirt backend of Installer to CRC team. For now I've only added two members from CRC team (myself and Praveen). I also added two members of Installer team who seem to have been the most active devs developing the relevant code. We don't add `libvirt-approvers` for `pkg/types/libvirt`. For reasons: openshift#1662 (comment)
zeenix
force-pushed
the
libvirt-ownership
branch
from
fb590f5
to
360b578
Compare
@wking Done. |
|
360b578 looks good to me, but I'll wait for @abhinavdahiya to sign off on it too. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, zeenix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-metal |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-metal |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@zeenix: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This is to give ownership of libvirt backend of Installer to CRC team. For now I've only added two members from CRC team (myself and Praveen). I also added two members of Installer team who seem to have been the most active devs developing the relevant code.