Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update terraform-provider-libvirt #1691

Merged
merged 1 commit into from May 14, 2019

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Apr 30, 2019

This pulls in the latest terraform-provider-libvirt which has a fix to
ensure the RNG is properly seeded. Otherwise random mac addresses end up
being deterministic in libvirt.

Pulls in the change to the libvirt provider that was proposed in #1478

@openshift-ci-robot
Copy link
Contributor

Hi @stbenjam. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 30, 2019
@sdodson
Copy link
Member

sdodson commented Apr 30, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2019
@abhinavdahiya
Copy link
Contributor

Please update the commit message and PR description on https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#commit-message-format
to provide why the bump is required.

@stbenjam
Copy link
Member Author

Please update the commit message and PR description on https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#commit-message-format
to provide why the bump is required.

Of course, updated

@abhinavdahiya
Copy link
Contributor

/test e2e-libvirt

@abhinavdahiya
Copy link
Contributor

@zeenix i triggered the libvirt e2e. can you verify this bump doesn't break the libvirt installation.

@abhinavdahiya
Copy link
Contributor

/test e2e-libvirt

@trown
Copy link

trown commented Apr 30, 2019

/test e2e-openstack

@trown
Copy link

trown commented May 2, 2019

/retest

1 similar comment
@stbenjam
Copy link
Member Author

stbenjam commented May 3, 2019

/retest

@stbenjam
Copy link
Member Author

stbenjam commented May 3, 2019

Why is the libvirt e2e test failing?

error: build error: API error (404): {"message":"lstat /va...ub.com/openshift/installer/bin: no such file or directory"}

Is there something I can do to help get it fixed?

@zeenix
Copy link
Contributor

zeenix commented May 4, 2019

@stbenjam I think that's been address through #1699. I think this will need a rebase for tests to succeed again.

@stbenjam
Copy link
Member Author

stbenjam commented May 6, 2019

/test e2e-libvirt

@stbenjam
Copy link
Member Author

stbenjam commented May 7, 2019

Rebased, looks like e2e-libvirt is passing now.

This pulls in the latest terraform-provider-libvirt which has a fix to
ensure the RNG is properly seeded. Otherwise random mac addresses end up
being deterministic in libvirt.
@stbenjam
Copy link
Member Author

/test e2e-aws-upgrade

@stbenjam
Copy link
Member Author

Everything is passing here

@zeenix
Copy link
Contributor

zeenix commented May 14, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2019
@zeenix
Copy link
Contributor

zeenix commented May 14, 2019

/assign @abhinavdahiya

@abhinavdahiya
Copy link
Contributor

/test e2e-libvirt

@stbenjam
Copy link
Member Author

@abhinavdahiya e2e-libvirt passed

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, stbenjam, zeenix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2019
@openshift-merge-robot openshift-merge-robot merged commit b50ff5e into openshift:master May 14, 2019
@stbenjam stbenjam deleted the libvirt-vendor branch May 14, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. platform/libvirt size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants