New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: update terraform-provider-libvirt #1691
vendor: update terraform-provider-libvirt #1691
Conversation
Hi @stbenjam. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Please update the commit message and PR description on https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#commit-message-format |
d7525f8
to
a239575
Compare
Of course, updated |
/test e2e-libvirt |
@zeenix i triggered the libvirt e2e. can you verify this bump doesn't break the libvirt installation. |
/test e2e-libvirt |
/test e2e-openstack |
/retest |
1 similar comment
/retest |
Why is the libvirt e2e test failing?
Is there something I can do to help get it fixed? |
/test e2e-libvirt |
Rebased, looks like e2e-libvirt is passing now. |
This pulls in the latest terraform-provider-libvirt which has a fix to ensure the RNG is properly seeded. Otherwise random mac addresses end up being deterministic in libvirt.
/test e2e-aws-upgrade |
Everything is passing here |
/lgtm |
/assign @abhinavdahiya |
/test e2e-libvirt |
@abhinavdahiya e2e-libvirt passed |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, stbenjam, zeenix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pulls in the latest terraform-provider-libvirt which has a fix to
ensure the RNG is properly seeded. Otherwise random mac addresses end up
being deterministic in libvirt.
Pulls in the change to the libvirt provider that was proposed in #1478