Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OWNERS_ALIASES: Define aliases for reviewers and approvers #184

Merged
merged 1 commit into from
Aug 31, 2018
Merged

OWNERS_ALIASES: Define aliases for reviewers and approvers #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Before creating your PR, please make sure to add the appropriate GitHub label; i.e. `run-smoke-tests`. For more details see
[tests/README.md](../tests/README.md).

(In case you don't have permissions to add labels, please ask a [maintainer](../OWNERS).)
(In case you don't have permissions to add labels, please ask [a](../OWNERS) [maintainer](../OWNERS_ALIASES).)
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ For contributors who want to work up pull requests, the workflow is roughly:
```
Note that a portion of the docs and examples are generated and that the generated files are to be committed by you. `make structure-check` checks that what is generated is what you must commit.
7. Submit a pull request to the original repository.
8. The [repo owners](OWNERS) will respond to your issue promptly, following [the ususal Prow workflow][prow-review].
8. The [repo](OWNERS) [owners](OWNERS_ALIASES) will respond to your issue promptly, following [the ususal Prow workflow][prow-review].

Thanks for your contributions!

Expand Down
10 changes: 3 additions & 7 deletions OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- aaronlevy
- abhinavdahiya
- crawford
- smarterclayton
- wking
- yifan-gu
- installer-approvers
reviewers:
- vikramsk
- installer-reviewers
12 changes: 12 additions & 0 deletions OWNERS_ALIASES
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# See the OWNERS_ALIASES docs: https://git.k8s.io/community/contributors/guide/owners.md#OWNERS_ALIASES

aliases:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also put @staebler and @rajatchopra here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also put @staebler and @rajatchopra here

This PR is already in the merge queue, so instead of pulling it out, I'll just file a follow-up PR adding them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

installer-approvers:
- aaronlevy
- abhinavdahiya
- crawford
- smarterclayton
- wking
- yifan-gu
installer-reviewers:
- vikramsk
2 changes: 1 addition & 1 deletion tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ In addition to our basic set of tests we have smoke tests which are running on A
### FAQ
- *I am not able to add labels, what should I do?*

Please ask one of [the repository maintainers](../OWNERS) to add the
Please ask one of the [repository](../OWNERS) [maintainers](../OWNERS_ALIASES) to add the
labels.

- *How do I retrigger the tests?*
Expand Down