Documentation: update installconfig #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
|
Needs a rebase with #188 landed, but otherwise looks good to me :). |
also drops previous work as it confuses people and serves little purpose.
abhinavdahiya
force-pushed
the
doc_installconfig
branch
from
4e7bd18
to
0a57de7
Compare
|
@wking rebased against master. PTAL. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
EmilienM
pushed a commit
to shiftstack/installer
that referenced
this pull request
Dec 8, 2020
* move rbac from hard code to generate use control-gen tool to generate rbac/rbac_role*.yaml files instead of hard code them Fixes openshift#155 * make crd file generated automatically use go run vendor/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go crd to create instead of using hard code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also drops previous work as it confuses people and serves little purpose.
/cc @yifan-gu @wking
/assign @wking @yifan-gu
NOTE: switch on
hide whitespaces changesfor better visibility.