Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1722221: [release-4.1] blank api version #1903

Merged
merged 2 commits into from Jun 25, 2019
Merged

Bug 1722221: [release-4.1] blank api version #1903

merged 2 commits into from Jun 25, 2019

Conversation

patrickdillon
Copy link
Contributor

@patrickdillon patrickdillon commented Jun 25, 2019 •
edited

Currently the error returned is failed to upconvert install config: cannot upconvert from version and empty version is not visible to users explicitly.

Combines (supercedes) #1764 & #1901

4.2.0 bz: https://bugzilla.redhat.com/show_bug.cgi?id=1723565
/cc @eparis

abhinavdahiya and others added 2 commits June 25, 2019 12:25
@abhinavdahiya @patrickdillon
types/conversion: return no version provided error when trying to con…
01f1505 
…vert

Currently the error returned is `failed to upconvert install config: cannot upconvert from version ` and empty version is not
visible to users explicitly.
@patrickdillon
Add conversion test when no API version is specified.
03e508f 
Adds a unit test for 4bea183. Adds further logic to conversion testing to allow for expected errors vs expected configs.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 25, 2019
@eparis eparis changed the title Release 4 1 blank api version Bug 1722221: Release 4 1 blank api version Jun 25, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 25, 2019
@openshift-ci-robot
Copy link
Contributor

@patrickdillon: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1722221: Release 4 1 blank api version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@patrickdillon: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1722221: Release 4 1 blank api version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis eparis changed the title Bug 1722221: Release 4 1 blank api version Bug 1722221: [release-4.1] blank api version Jun 25, 2019
@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 25, 2019
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2019
@eparis eparis mentioned this pull request Jun 25, 2019
Closed
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2019
@eparis eparis mentioned this pull request Jun 25, 2019
Closed
@openshift-merge-robot openshift-merge-robot merged commit 8aa5b10 into openshift:release-4.1 Jun 25, 2019
rcarrata pushed a commit to rcarrata/installer that referenced this pull request Jul 12, 2019
@openshift-merge-robot @rcarrata
Merge pull request openshift#1903 from patrickdillon/release-4-1-blan…
e520cb9 
…k-api-version

Bug 1722221: [release-4.1] blank api version
@patrickdillon patrickdillon deleted the release-4-1-blank-api-version branch October 24, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eparis eparis Awaiting requested review from eparis

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@patrickdillon @openshift-ci-robot @abhinavdahiya @eparis @openshift-merge-robot