New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libvirt: simplify how bootstrap_dns is passed to terraform #1995
libvirt: simplify how bootstrap_dns is passed to terraform #1995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! Couple of suggestions inline
/label platform/libvirt |
This change simplifies libvirt's passing of the bootstrap_dns variable to terraform when tearing down the bootstrap components. It is now more like like the corresponding gcp code. Instead of writing a vars file to disk, it is now set as a command line argument.
e06f7db
to
af67201
Compare
/lgtm |
/approve |
On bot's instructions: |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, jstuever, markmc, zeenix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@jstuever: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This change simplifies libvirt's passing of the bootstrap_dns variable to
terraform when tearing down the bootstrap components. It is now more like like
the corresponding gcp code. Instead of writing a vars file to disk, it is now
set as a command line argument.