New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules/aws/ami: Use implicit provider inheritance #213

Merged

openshift-merge-robot merged 1 commit into openshift:master from wking:implicit-provider-inheritance

Sep 6, 2018

Commits on Sep 6, 2018

modules/aws/ami: Use implicit provider inheritance

Docs in [1], where they say:

  This approach is recommended in the common case where only a single
  configuration is needed for each provider across the entire
  configuration.

I didn't know about implicit provider inheritance when I landed the
module in b23621f (modules/aws/ami: Add a new module to get CoreOS
AMIs, 2018-07-31, openshift#84).  We'll probably drop this module soon as we
move to Red Hat CoreOS, but I worked up the change while looking for
patterns to follow for a bootstrap module.

The module source syntax used in the README is documented in [2,3,4],
and means "the modules/aws/ami subdirectory of the
github.com/openshift/installer repository cloned over HTTPS".

[1]: https://www.terraform.io/docs/modules/usage.html#implicit-provider-inheritance
[2]: https://www.terraform.io/docs/configuration/modules.html#source
[3]: https://www.terraform.io/docs/modules/sources.html#github
[4]: https://www.terraform.io/docs/modules/sources.html#modules-in-package-sub-directories

wking committed Sep 6, 2018