Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data/bootstrap/files/usr/local/bin/bootkube.sh.template: Drop OPENSHIFT_HYPERSHIFT_IMAGE #2131

Merged
merged 1 commit into from Aug 1, 2019
Merged

data/bootstrap/files/usr/local/bin/bootkube.sh.template: Drop OPENSHIFT_HYPERSHIFT_IMAGE #2131

merged 1 commit into from Aug 1, 2019

Conversation

wking
Copy link
Member

@wking wking commented Jul 31, 2019

The last consumer was removed in 8c58a99 (#1885).

@wking
data/bootstrap/files/usr/local/bin/bootkube.sh.template: Drop OPENSHI…
7c3a9d3 
…FT_HYPERSHIFT_IMAGE

The last consumer was removed in 8c58a99 (bootkube: pass the
hyperkube image as main image, 2019-06-21, openshift#1885).
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2019
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member Author

wking commented Jul 31, 2019 •
edited

In the retest now, but the earlier e2e-aws failed with rhbz#1726328:

[sig-autoscaling]  [HPA] Horizontal pod autoscaling (scale resource: CPU)  [sig-autoscaling] ReplicationController light Should scale from 2 pods  to 1 pod [Suite:openshift/conformance/parallel] [Suite:k8s] expand_less | 15m30s

...
Jul 31 20:41:47.161: INFO: waiting for 1 replicas (current: 2) 
...
Received interrupt. Running AfterSuite...
^C again to terminate immediately 
...

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c23046e into openshift:master Aug 1, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 7c3a9d3 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking wking deleted the drop-openshift-hypershift-image branch August 1, 2019 19:08
@DanyC97 DanyC97 mentioned this pull request Sep 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@jhixson74 jhixson74 Awaiting requested review from jhixson74

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wking @abhinavdahiya @openshift-ci-robot @openshift-bot @openshift-merge-robot