Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform: update aws, azure, google providers to latest #2396

Closed
wants to merge 5 commits into from

Conversation

abhinavdahiya
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 24, 2019
@abhinavdahiya
Copy link
Contributor Author

/test e2e-gcp

/test e2e-azure

@abhinavdahiya abhinavdahiya changed the title terraform: update aws, azure, google providers to latest WIP: terraform: update aws, azure, google providers to latest Sep 24, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2019
@wking
Copy link
Member

wking commented Sep 24, 2019

Lots of:

pkg/terraform/exec/vendor/github.com/hashicorp/go-retryabl...e *http.Client has no field or method CloseIdleConnections)

Needs a Go bump?

0.12.9 version brings new new dependency on alibaba-cloud-sdk, which requires overrides to work correctly with aws-sdk-go

The other overrides are almost similar
@abhinavdahiya abhinavdahiya changed the title WIP: terraform: update aws, azure, google providers to latest terraform: update aws, azure, google providers to latest Sep 24, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2019
@metal3ci
Copy link

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1165/

@abhinavdahiya
Copy link
Contributor Author

/test e2e-gcp

/test e2e-azure

@abhinavdahiya
Copy link
Contributor Author

/retest

@stbenjam
Copy link
Member

/lgtm

baremetal IPI is working fine with this PR, got a good install locally

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Contributor Author

/retest

@abhinavdahiya
Copy link
Contributor Author

/hold

/test e2e-azure

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2019
@abhinavdahiya
Copy link
Contributor Author

/test e2e-gcp

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@abhinavdahiya
Copy link
Contributor Author

/test e2e-azure

/test e2e-gcp

@abhinavdahiya
Copy link
Contributor Author

pushed 68631f5 to fix the deprecation notices and errors in https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_installer/2396/pull-ci-openshift-installer-master-e2e-azure/191

left the private zone one, as that needs more work for now.

@abhinavdahiya
Copy link
Contributor Author

need few fixes in the azure provider to use the private_dns resources that were introduced in 1.34.0

hashicorp/terraform-provider-azurerm#4452
hashicorp/terraform-provider-azurerm#4453

@abhinavdahiya
Copy link
Contributor Author

/test e2e-azure

/test e2e-gcp

@abhinavdahiya
Copy link
Contributor Author

/retest

@abhinavdahiya
Copy link
Contributor Author

/test e2e-azure

@patrickdillon
Copy link
Contributor

/test e2e-azure

looks like it failed with a boskos error

@abhinavdahiya
Copy link
Contributor Author

/test e2e-gcp

/test e2e-azure

@abhinavdahiya
Copy link
Contributor Author

still need fixes from hashicorp/terraform-provider-azurerm#4501 and hashicorp/terraform-provider-azurerm#4453 for azure provider

@abhinavdahiya
Copy link
Contributor Author

/refresh

@abhinavdahiya
Copy link
Contributor Author

/test all

@abhinavdahiya
Copy link
Contributor Author

/skip

@abhinavdahiya
Copy link
Contributor Author

/test all

@abhinavdahiya
Copy link
Contributor Author

/test e2e-azure

@abhinavdahiya
Copy link
Contributor Author

/test e2e-gcp

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 4, 2019

@abhinavdahiya: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-disruptive 365dfda link /test e2e-aws-disruptive
ci/prow/e2e-aws 365dfda link /test e2e-aws
ci/prow/e2e-aws-scaleup-rhel7 365dfda link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-aws-upgrade 365dfda link /test e2e-aws-upgrade
ci/prow/e2e-gcp 365dfda link /test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Contributor Author

/close

@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants