Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Bug 1753930: Adds GCP metadata hostnames to default noProxy #2407

Merged
merged 1 commit into from Sep 26, 2019
Merged

Fixes Bug 1753930: Adds GCP metadata hostnames to default noProxy #2407

merged 1 commit into from Sep 26, 2019

Conversation

danehans
Copy link
Contributor

Adds GCP metadata hostnames to default noProxy according to https://cloud.google.com/vpc/docs/special-configurations

@openshift-ci-robot
Copy link
Contributor

@danehans: This pull request references Bugzilla bug 1753930, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes Bug 1753930: Adds GCP metadata hostnames to default noProxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2019
@abhinavdahiya
Copy link
Contributor

Please follow the guidelines around commit messages mentioned here https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#commit-message-format

a) include the scope asset/manifests
b) the commit body should optionally include the descriptions of the why.

@danehans
Copy link
Contributor Author

Please follow the guidelines around commit messages

@abhinavdahiya I updated the commit message based on the guidelines.

@danehans
asset/manifests: Adds GCP metadata hostnames to default noProxy
8b2bdad 
Previously, only the metadata IP address was included in the
default noProxy list. This causes calls to GCP metadata using
hostnames to be proxied. The GCP metadata hostnames are based on:

https://cloud.google.com/vpc/docs/special-configurations
@jstuever
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2019
@abhinavdahiya
Copy link
Contributor

/approve

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, danehans, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2019
@openshift-merge-robot openshift-merge-robot merged commit 01a81cd into openshift:master Sep 26, 2019
@wking
Copy link
Member

wking commented Sep 26, 2019

@danehans, is there a 4.2 backport bug yet? If not, can you file one?

@danehans
Copy link
Contributor Author

danehans commented Oct 7, 2019

/cherry-pick release-4.2

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 7, 2019
Merged
@openshift-cherrypick-robot
Copy link

@danehans: new pull request created: #2465

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@jstuever jstuever

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@danehans @openshift-ci-robot @abhinavdahiya @jstuever @wking @openshift-cherrypick-robot @openshift-merge-robot