asset/manifests/infrastructure.go: Set the network resource group for the Azure cluster #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The k8s libs need to be updated because the openshift/api now uses 1.16.0 version. Without this the build fails with error: ``` vendor/github.com/openshift/api/route/v1/generated.pb.go:448:28: m.ObjectMeta.MarshalToSizedBuffer undefined (type "github.com/openshift/installer/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".ObjectMeta has no field or method MarshalToSizedBuffer) vendor/github.com/openshift/api/route/v1/generated.pb.go:539:37: m.LastTransitionTime.MarshalToSizedBuffer undefined (type *"github.com/openshift/installer/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".Time has no field or method MarshalToSizedBuffer) vendor/github.com/openshift/api/route/v1/generated.pb.go:607:26: m.ListMeta.MarshalToSizedBuffer undefined (type "github.com/openshift/installer/vendor/k8s.io/apimachinery/pkg/apis/meta/v1".ListMeta has no field or method MarshalToSizedBuffer) vendor/github.com/openshift/api/route/v1/generated.pb.go:640:28: m.TargetPort.MarshalToSizedBuffer undefined (type intstr.IntOrString has no field or method MarshalToSizedBuffer) vendor/github.com/openshift/client-go/config/clientset/versioned/typed/config/v1/config_client.go:132:45: scheme.Codecs.WithoutConversion undefined (type serializer.CodecFactory has no field or method WithoutConversion) ```
|
/test e2e-azure |
openshift-ci-robot
added
size/XXL
abhinavdahiya
force-pushed
the
azure_fix_n_rg
branch
from
1820066
to
972691c
Compare
|
/test e2e-azure |
|
With this change, the byo-vnet settings originally from #2441 (comment) no longer require the additional step of adding machine-api-operator permissions on the network resource group. |
jhixson74
approved these changes
Oct 21, 2019
|
/lgtm |
|
/retest |
|
/test e2e-gcp |
The bump was done using ``` $ dep version dep: version : v0.5.0 build date : 2018-07-26 git hash : 224a564 go version : go1.10.3 go compiler : gc platform : linux/amd64 features : ImportDuringSolve=false $ dep ensure -update -v github.com/openshift/api github.com/openshift/client-go ```
29bba80 [1] switched off the glog output to highest and had the flag trick to prevent glog flags from showing up. With switch to kubernetes-1.16.0, all the k8s libs are using klog [2], that doesn't add the flags and also allows to set the default Ouput writer for all levels. Setting the klog output to ioutil.Discard keeps the current behavior [1]: openshift@29bba80 [2]: https://godoc.org/k8s.io/klog
… the Azure cluster The network resource group is the same as the cluster resource group, unless the Vnet and subnets were provided by the user to the installer.
abhinavdahiya
force-pushed
the
azure_fix_n_rg
branch
from
972691c
to
3165e5f
Compare
|
/test e2e-azure |
|
/test e2e-gcp |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, jhixson74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network resource group is the same as the cluster resource group, unless the Vnet and subnets were provided by the user to the installer.
The new field was added by openshift/api#463
Keeping the network resource group empty is same setting it to cluster resource group, but i think setting it explicitly is more accurate and visible.
/assign @jhixson74